debug testS3WorkflowPush failure

Author: drernie

lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowConfig.java

@@ -186,13 +186,15 @@ public WorkflowValidator getWorkflowValidator(String workflow) throws WorkflowEx
         Pattern pkgNamePattern = pkgNamePatternNode != null ? Pattern.compile(pkgNamePatternNode.asText()) : null;
 
         JsonNode metadataSchemaId = workflowData.get("metadata_schema");
+        logger.info("metadataSchemaId={}", metadataSchemaId);
         Validator metadataValidator = metadataSchemaId != null ? makeValidatorFromSchema(metadataSchemaId.asText()) : null;
 
         JsonNode entriesSchemaId = workflowData.get("entries_schema");
+        logger.info("entriesSchemaId={}", entriesSchemaId);
         Validator entriesValidator = entriesSchemaId != null ? makeValidatorFromSchema(entriesSchemaId.asText()) : null;
 
         JsonNode isMessageRequiredNode = workflowData.get("is_message_required");
-        boolean isMessageRequired = isMessageRequiredNode != null ? isMessageRequiredNode.asBoolean(false) : false;
+        boolean isMessageRequired = isMessageRequiredNode != null && isMessageRequiredNode.asBoolean(false);
 
         var dataToStore = JsonNodeFactory.instance.objectNode()
             .put("id", workflow.isEmpty() ? null : workflow)
@@ -225,7 +227,7 @@ private Validator makeValidatorFromSchema(String schemaId) throws ConfigurationE
         JsonNode schemaNode;
         PhysicalKey schemaEffectivePhysicalKey;
 
-        logger.debug("Loading schema from {}", schemaPhysicalKey);
+        logger.info("Loading schema from {}", schemaPhysicalKey);
         try {
             var response = schemaPhysicalKey.open();
             schemaNode = mapper.readTree(response.inputStream);
@@ -252,6 +254,7 @@ private Validator makeValidatorFromSchema(String schemaId) throws ConfigurationE
         JsonSchemaOptions options = new JsonSchemaOptions()
             .setBaseUri("https://quiltdata.com/")  // TODO: remove it; not actually used.
             .setDraft(draft);
+        logger.info("Creating validator for schema {} with options {}", schema, options);
         Validator validator = Validator.create(schema, options);
 
         info = new SchemaInfo(validator, schemaEffectivePhysicalKey);
@@ -271,9 +274,7 @@ private PhysicalKey getPhysicalKeyForSchemaId(String schemaId) throws Configurat
         logger.debug("Resolving schema URL: {}", schemaUrl);
         try {
             schemaPk = PhysicalKey.fromUri(new URI(schemaUrl));
-        } catch (IllegalArgumentException e) {
-            throw new ConfigurationException("Couldn't parse URL: " + schemaUrl, e);
-        } catch (URISyntaxException e) {
+        } catch (IllegalArgumentException | URISyntaxException e) {
             throw new ConfigurationException("Couldn't parse URL: " + schemaUrl, e);
         }
 

lib/src/main/java/com/quiltdata/quiltcore/workflows/WorkflowValidator.java

@@ -125,7 +125,7 @@ private void validateMessage(String message) throws WorkflowException {
      * @return The entry for validation.
      */
     private static Map<String, Object> entryForValidation(ObjectMapper mapper, String logicalKey, Entry entry) {
-        logger.debug("entryForValidation: logicalKey={}, entry={}", logicalKey, entry);
+        logger.info("entryForValidation: logicalKey={}, entry={}", logicalKey, entry);
         try {
             return Map.of(
                 "logical_key", logicalKey,
@@ -157,6 +157,7 @@ private void validateEntries(ObjectMapper mapper, Map<String, Entry> entries) th
 
         OutputUnit output = entriesValidator.validate(entriesForValidation);
         if (!output.getValid()) {
+            logger.error("validateEntries: {} for validator: {}", entriesForValidation, entriesValidator);
             throw new WorkflowException("Package entries failed validation");
         }
     }
@@ -179,6 +180,7 @@ private void validateMetadata(ObjectMapper mapper, ObjectNode metadata) throws W
         try {
             OutputUnit output = metadataValidator.validate(mapper.treeToValue(userMeta, Object.class));
             if (!output.getValid()) {
+                logger.error("validateMetadata: {} for validator: {}", userMeta, metadataValidator);
                 throw new WorkflowException("Metadata failed validation");
             }
         } catch (JsonProcessingException e) {