Skip to content

Commit b5d23a8

Browse files
link2xtRalith
authored andcommitted
Remove "max_tlps" configuration variable
It is not used since <#134> (commit bdc9ac7) was merged in 2018. RFC 9002 also does not mention Tail Loss Probe except that it has been integrated into the PTO (Probe Timeout) mechanism.
1 parent d1bb2b8 commit b5d23a8

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

quinn-proto/src/config.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ pub struct TransportConfig {
3232
pub(crate) receive_window: VarInt,
3333
pub(crate) send_window: u64,
3434

35-
pub(crate) max_tlps: u32,
3635
pub(crate) packet_threshold: u32,
3736
pub(crate) time_threshold: f32,
3837
pub(crate) initial_rtt: Duration,
@@ -135,12 +134,6 @@ impl TransportConfig {
135134
self
136135
}
137136

138-
/// Maximum number of tail loss probes before an RTO fires.
139-
pub fn max_tlps(&mut self, value: u32) -> &mut Self {
140-
self.max_tlps = value;
141-
self
142-
}
143-
144137
/// Maximum reordering in packet number space before FACK style loss detection considers a
145138
/// packet lost. Should not be less than 3, per RFC5681.
146139
pub fn packet_threshold(&mut self, value: u32) -> &mut Self {
@@ -331,7 +324,6 @@ impl Default for TransportConfig {
331324
receive_window: VarInt::MAX,
332325
send_window: (8 * STREAM_RWND).into(),
333326

334-
max_tlps: 2,
335327
packet_threshold: 3,
336328
time_threshold: 9.0 / 8.0,
337329
initial_rtt: Duration::from_millis(333), // per spec, intentionally distinct from EXPECTED_RTT
@@ -365,7 +357,6 @@ impl fmt::Debug for TransportConfig {
365357
stream_receive_window,
366358
receive_window,
367359
send_window,
368-
max_tlps,
369360
packet_threshold,
370361
time_threshold,
371362
initial_rtt,
@@ -391,7 +382,6 @@ impl fmt::Debug for TransportConfig {
391382
.field("stream_receive_window", stream_receive_window)
392383
.field("receive_window", receive_window)
393384
.field("send_window", send_window)
394-
.field("max_tlps", max_tlps)
395385
.field("packet_threshold", packet_threshold)
396386
.field("time_threshold", time_threshold)
397387
.field("initial_rtt", initial_rtt)

0 commit comments

Comments
 (0)