Skip to content

Commit f642fa8

Browse files
committed
ci: Change powerset check
The existing powerset check has problems: - It takes too long. - It failed to catch all the bugs fixed in the previous commit. This commit fixes it as such: - `--depth 3` is passed in which limits execution time. - `--group-features` groups are removed which would have caught the bugs fixed in the previous commit. - `--clean-per-run` is removed as it's no longer necessary and slows it down. Experimentation indicates that a depth of 3 takes roughly a few minutes to execute and catches bugs, whereas a depth of 4 takes roughly 40 minutes to run and does not catch any additional bugs.
1 parent 14b905a commit f642fa8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/rust.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,4 +286,4 @@ jobs:
286286
- uses: actions/checkout@v4
287287
- uses: dtolnay/rust-toolchain@stable
288288
- uses: taiki-e/install-action@cargo-hack
289-
- run: cargo hack check --feature-powerset --optional-deps --clean-per-run --no-dev-deps --ignore-unknown-features --ignore-private --group-features runtime-async-std,async-io,async-std --group-features runtime-smol,async-io,smol --skip "${{env.SKIP_FEATURES}}"
289+
- run: cargo hack check --feature-powerset --depth 3 --optional-deps --no-dev-deps --ignore-private --skip "${{env.SKIP_FEATURES}}"

0 commit comments

Comments
 (0)