(Draft) Public write_source API
#2231
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR currently targets a temporary base branch formed by merging #2230 and #2226 into main.
Overall, this PR makes the refactored
write_sourceAPI proposed in #2230 public and threads it through to a public API in Quinn as well. This has value both for simplicity and utility. From the simplicity side, it allows us to supersede and delete thequinn::SendStream::execute_pollfunction.From the utility side, this API, for example, should be considered to close #2229, as it could be used to implement a
write_atomicmethod purely on top of existing public methods as such: