Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Commit 3a55e98

Browse files
committed
Fixes #17
* [r] Bumps app version and SDK version * [f] Adds supports for RTL layouts * [u] Upgrades dependencies * [b] Fixes popup view for RTL
1 parent 11e9a1d commit 3a55e98

File tree

5 files changed

+22
-15
lines changed

5 files changed

+22
-15
lines changed

gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ android.enableJetifier=true
1818
# ref: https://github.com/chrisbanes/gradle-mvn-push and
1919
# ref2: https://chris.banes.dev/2013/08/27/pushing-aars-to-maven-central/
2020

21-
VERSION_NAME=0.2.0
22-
VERSION_CODE=4
21+
VERSION_NAME=0.2.1
22+
VERSION_CODE=5
2323
GROUP=com.quiph.ui
2424

2525
POM_DESCRIPTION=A modern implementation of the RecyclerViewFastScroller for Android written in Kotlin

recyclerviewfastscroller/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ android {
88
minSdkVersion versions.'minSdk'
99
targetSdkVersion versions.'targetSdk'
1010
versionCode 4
11-
versionName "0.2.0"
11+
versionName "0.2.1"
1212

1313
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
1414

@@ -30,13 +30,13 @@ dependencies {
3030
implementation 'org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.3.72'
3131

3232
// support libs
33-
implementation 'androidx.recyclerview:recyclerview:1.2.0-alpha04'
33+
implementation 'androidx.recyclerview:recyclerview:1.2.0-alpha05'
3434
implementation 'androidx.appcompat:appcompat:1.3.0-alpha01'
3535

3636
// testing libs
3737
testImplementation 'junit:junit:4.13-beta-3'
38-
androidTestImplementation 'androidx.test:runner:1.3.0-rc01'
39-
androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0-rc01'
38+
androidTestImplementation 'androidx.test:runner:1.3.0-rc03'
39+
androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0-rc03'
4040
}
4141
repositories {
4242
mavenCentral()

recyclerviewfastscroller/src/main/java/com/qtalk/recyclerviewfastscroller/RecyclerViewFastScroller.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,10 +402,10 @@ class RecyclerViewFastScroller @JvmOverloads constructor(
402402
LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT).also {
403403
when (popupPosition) {
404404
PopupPosition.BEFORE_TRACK -> {
405-
it.addRule(LEFT_OF, trackView.id)
405+
it.addRule(START_OF, trackView.id)
406406
}
407407
PopupPosition.AFTER_TRACK -> {
408-
it.addRule(RIGHT_OF, trackView.id)
408+
it.addRule(END_OF, trackView.id)
409409
}
410410
}
411411
}
@@ -427,7 +427,7 @@ class RecyclerViewFastScroller @JvmOverloads constructor(
427427
LayoutParams(
428428
LayoutParams.WRAP_CONTENT,
429429
LayoutParams.MATCH_PARENT
430-
).also { it.addRule(ALIGN_PARENT_RIGHT) }
430+
).also { it.addRule(ALIGN_PARENT_END) }
431431
}
432432
}
433433
handleImageView.layoutParams = lp

sample/build.gradle

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ android {
77
applicationId "com.qtalk.sample"
88
minSdkVersion versions.'minSdk'
99
targetSdkVersion versions.'targetSdk'
10-
versionCode 2
11-
versionName "1.1"
10+
versionCode 3
11+
versionName "1.2"
1212

1313
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
1414

@@ -38,12 +38,12 @@ dependencies {
3838
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
3939
implementation deps.gson
4040
implementation 'androidx.appcompat:appcompat:1.3.0-alpha01'
41-
implementation 'androidx.recyclerview:recyclerview:1.2.0-alpha04'
41+
implementation 'androidx.recyclerview:recyclerview:1.2.0-alpha05'
4242

43-
implementation 'androidx.constraintlayout:constraintlayout:2.0.0-beta8'
43+
implementation 'androidx.constraintlayout:constraintlayout:2.0.0-rc1'
4444

4545
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
4646
testImplementation 'junit:junit:4.13-beta-3'
47-
androidTestImplementation 'androidx.test:runner:1.3.0-rc01'
48-
androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0-rc01'
47+
androidTestImplementation 'androidx.test:runner:1.3.0-rc03'
48+
androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0-rc03'
4949
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<shape xmlns:android="http://schemas.android.com/apk/res/android">
3+
<corners android:bottomRightRadius="@dimen/contacts_fastscroller_radius"
4+
android:topLeftRadius="@dimen/contacts_fastscroller_radius"
5+
android:topRightRadius="@dimen/contacts_fastscroller_radius"/>
6+
<solid android:color="@color/colorPrimary" />
7+
</shape>

0 commit comments

Comments
 (0)