Skip to content

Commit cc26bb9

Browse files
authored
add node v19 support (#1130)
Closes #1129
1 parent 851861f commit cc26bb9

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414

1515
strategy:
1616
matrix:
17-
node-version: [14, 16, 18]
17+
node-version: [14, 16, 18, 19]
1818
fail-fast: false
1919

2020
services:
@@ -38,31 +38,32 @@ jobs:
3838
- uses: actions/setup-node@v3
3939
with:
4040
node-version: ${{ matrix.node-version }}
41-
- if: ${{ matrix.node-version == 14 }}
41+
- if: ${{ matrix.node-version == 18 }}
4242
uses: microsoft/playwright-github-action@v1
4343
- run: npm i -g npm@7
44+
- run: npm explore npm/node_modules/@npmcli/run-script -g -- npm_config_global=false npm install node-gyp@latest
4445
- run: npm ci
4546
- run: npm run build
4647
- run: npm test -- --coverage
47-
- if: ${{ matrix.node-version == 14 }}
48+
- if: ${{ matrix.node-version == 18 }}
4849
name: Coveralls Quirrel
4950
uses: coverallsapp/github-action@master
5051
with:
5152
flag-name: quirrel
5253
github-token: ${{ secrets.GITHUB_TOKEN }}
5354
path-to-lcov: coverage/lcov.info
5455
parallel: true
55-
- if: ${{ matrix.node-version == 14 }}
56+
- if: ${{ matrix.node-version == 18 }}
5657
run: npm ci
5758
working-directory: development-ui
58-
- if: ${{ matrix.node-version == 14 }}
59+
- if: ${{ matrix.node-version == 18 }}
5960
name: Install Playwright Browsers
6061
run: npx playwright install --with-deps
6162
working-directory: development-ui
62-
- if: ${{ matrix.node-version == 14 }}
63+
- if: ${{ matrix.node-version == 18 }}
6364
run: npm run test:ci
6465
working-directory: development-ui
65-
- if: ${{ matrix.node-version == 14 }}
66+
- if: ${{ matrix.node-version == 18 }}
6667
name: Coveralls Finished
6768
uses: coverallsapp/github-action@master
6869
with:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"module": "dist/esm/src/index.js",
2222
"version": "1.13.3",
2323
"engines": {
24-
"node": "14 || 15 || 16 || 17 || 18"
24+
"node": "14 || 15 || 16 || 17 || 18 || 19"
2525
},
2626
"bin": {
2727
"quirrel": "cli.js"

0 commit comments

Comments
 (0)