Skip to content

Commit a0971f7

Browse files
authored
Merge pull request #17 from quizizz/rohit/fixing-token-types
Rohit/fixing token types
2 parents 594a80d + 51066a9 commit a0971f7

File tree

6 files changed

+38
-25
lines changed

6 files changed

+38
-25
lines changed

src/canvas.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { AxiosResponse } from 'axios';
22
import { RequestConfig } from './types';
3-
import { Tokens, GetUserToken, SetUserToken, SubmissionStates } from './common';
3+
import { Tokens, SubmissionStates, GetAccessToken, SetAccessToken } from './common';
44

55
export interface AuthURLOptions {
66
state: string;
@@ -36,7 +36,7 @@ export interface CanvasOptions {
3636
refreshToken?: string;
3737
clientId: string;
3838
clientSecret: string;
39-
fxs: { getToken: GetUserToken, setToken: SetUserToken };
39+
fxs: { getToken: GetAccessToken, setToken: SetAccessToken };
4040
userId: string;
4141
canvasUserId?: string;
4242
}
@@ -51,8 +51,8 @@ export class Canvas {
5151
refreshToken?: string;
5252
clientId: string;
5353
clientSecret: string;
54-
getUserToken: GetUserToken;
55-
setUserToken: SetUserToken;
54+
getUserToken: GetAccessToken;
55+
setUserToken: SetAccessToken;
5656
userId: string;
5757
canvasUserId: string;
5858

src/canvas.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ class Canvas {
223223
}
224224
try {
225225
await this.refreshUserToken(this.refreshToken);
226-
} catch (err) {
227-
console.error(err);
226+
} catch (err1) {
227+
console.error(err1);
228228
}
229229

230230
const resp = await this.makeRequest(requestConfig, retries + 1);

src/common.d.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
export interface Tokens {
2-
accessToken: string;
3-
refreshToken: string;
4-
canvasUserId: string;
2+
access_token?: string,
3+
access_token_secret?: string,
4+
token_type?: string,
5+
expires_in?: Number,
6+
refresh_token?: string,
7+
lastRefresh?: Date,
8+
info?: any,
59
}
610

7-
export type GetUserToken = (userId: string) => Promise<Tokens>;
8-
export type SetUserToken = (userId: string, tokens: Tokens) => Promise<void>;
11+
export type GetAccessToken = (userId: string) => Promise<Tokens>;
12+
export type SetAccessToken = (userId: string, token: Tokens) => Promise<any>;
913

1014
export declare enum SubmissionStates {
1115
SUBMITTED = 'submitted',

src/gcl.d.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
/**
22
* @class GCL
33
*/
4-
export = GCL
4+
import { GetAccessToken, SetAccessToken } from "./common";
55
class GCL {
66
constructor(name: any, emitter: any, opts: any, urls?: {}, fxs?: {});
77
name: any;
88
emitter: any;
99
apiURL: any;
1010
authURL: any;
1111
tokenURL: any;
12-
getUserToken: any;
13-
setUserToken: any;
12+
getUserToken: GetAccessToken;
13+
setUserToken: SetAccessToken;
1414
authClient: any;
1515
requestClient({ refresh_token, access_token, lastRefresh }: {
1616
refresh_token: any;
@@ -89,4 +89,5 @@ class GCL {
8989
courseWorkId: any;
9090
subId: any;
9191
}): any;
92-
}
92+
}
93+
export = GCL

src/index.d.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@ import {
1414
import {
1515
Schoology,
1616
SchoologyOptions,
17+
SchoologyGetAccessToken,
18+
SchoologySetAccessToken,
1719
} from "./schoology";
1820
import {
1921
Tokens,
20-
GetUserToken,
21-
SetUserToken,
2222
SubmissionStates,
23+
GetAccessToken,
24+
SetAccessToken,
2325
} from "./common";
2426
import {
2527
RequestToken,
@@ -38,18 +40,20 @@ export {
3840
LMSError,
3941
Schoology,
4042
SchoologyOptions,
43+
SchoologyGetAccessToken,
44+
SchoologySetAccessToken,
4145
AuthURLOptions,
4246
CanvasProfile,
4347
CanvasOptions,
4448
Canvas,
49+
GetAccessToken,
50+
SetAccessToken,
4551
GradeSubmissionResponse,
4652
Course,
4753
Student,
4854
Submission,
4955
Assignment,
5056
Tokens,
51-
GetUserToken,
52-
SetUserToken,
5357
SubmissionStates,
5458
RequestToken,
5559
AccessToken,

src/schoology.d.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import { RequestToken, AccessToken } from './oauth';
2-
import { GetUserToken, SetUserToken, SubmissionStates } from './common';
2+
import { SubmissionStates, Tokens } from './common';
33

44
export interface SchoologyOptions {
55
schoologyProfileId: string;
66
requestToken?: RequestToken;
77
accessToken?: AccessToken;
88
fxs: {
9-
cacheRequestToken?: (any) => Promise<any>;
10-
getAccessToken?: GetUserToken;
11-
setAccessToken?: SetUserToken;
9+
cacheRequestToken?: (token: AccessToken) => Promise<any>;
10+
getAccessToken?: SchoologyGetAccessToken;
11+
setAccessToken?: SchoologySetAccessToken;
1212
};
1313
hostedUrl: string;
1414
redirectUri: string;
@@ -17,6 +17,10 @@ export interface SchoologyOptions {
1717
userId: string;
1818
}
1919

20+
// The structure it works on is different, it uses the OAuth Token Structure
21+
export type SchoologyGetAccessToken = () => Promise<AccessToken>;
22+
export type SchoologySetAccessToken = (token: AccessToken) => Promise<any>;
23+
2024
export class Schoology {
2125
constructor(options: SchoologyOptions);
2226

@@ -27,8 +31,8 @@ export class Schoology {
2731
userId: string;
2832
schoologyProfileId: string;
2933
cacheRequestToken: (any) => Promise<any>;
30-
getUserToken: GetUserToken;
31-
setUserToken: SetUserToken;
34+
getUserToken: SchoologyGetAccessToken;
35+
setUserToken: SchoologySetAccessToken;
3236
oAuth: OAuth;
3337

3438
static SUBMISSION_STATE: SubmissionStates;

0 commit comments

Comments
 (0)