Skip to content

Commit 02b4c8e

Browse files
authored
Fix eslint v9 compatibility issues (#532)
* Fix deprecated API usage for eslint v9 compatibility * Fix linting * Ignore coverage for code paths not traversed by modern eslint
1 parent a74e161 commit 02b4c8e

File tree

5 files changed

+49
-10
lines changed

5 files changed

+49
-10
lines changed

lib/rules/no-assert-equal.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,17 @@ module.exports = {
136136
testStack.pop();
137137
}
138138
},
139-
Program: function () {
139+
Program: function (node) {
140140
// Gather all calls to global `equal()`.
141+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
142+
const sourceCode =
143+
context.sourceCode ?? context.getSourceCode();
144+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
145+
const scope = sourceCode.getScope
146+
? sourceCode.getScope(node)
147+
: context.getScope();
141148

142-
const tracker = new ReferenceTracker(context.getScope());
149+
const tracker = new ReferenceTracker(scope);
143150
const traceMap = { equal: { [ReferenceTracker.CALL]: true } };
144151

145152
for (const { node } of tracker.iterateGlobalReferences(

lib/rules/no-global-assertions.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,16 @@ module.exports = {
3333

3434
create: function (context) {
3535
return {
36-
Program: function () {
37-
const tracker = new ReferenceTracker(context.getScope());
36+
Program: function (node) {
37+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
38+
const sourceCode =
39+
context.sourceCode ?? context.getSourceCode();
40+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
41+
const scope = sourceCode.getScope
42+
? sourceCode.getScope(node)
43+
: context.getScope();
44+
45+
const tracker = new ReferenceTracker(scope);
3846
const traceMap = {};
3947
for (const assertionName of getAssertionNames()) {
4048
traceMap[assertionName] = { [ReferenceTracker.CALL]: true };

lib/rules/no-global-expect.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,16 @@ module.exports = {
3131

3232
create: function (context) {
3333
return {
34-
Program: function () {
35-
const tracker = new ReferenceTracker(context.getScope());
34+
Program: function (node) {
35+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
36+
const sourceCode =
37+
context.sourceCode ?? context.getSourceCode();
38+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
39+
const scope = sourceCode.getScope
40+
? sourceCode.getScope(node)
41+
: context.getScope();
42+
43+
const tracker = new ReferenceTracker(scope);
3644
const traceMap = { expect: { [ReferenceTracker.CALL]: true } };
3745

3846
for (const { node } of tracker.iterateGlobalReferences(

lib/rules/no-global-module-test.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,16 @@ module.exports = {
3131

3232
create: function (context) {
3333
return {
34-
Program: function () {
35-
const tracker = new ReferenceTracker(context.getScope());
34+
Program: function (node) {
35+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
36+
const sourceCode =
37+
context.sourceCode ?? context.getSourceCode();
38+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
39+
const scope = sourceCode.getScope
40+
? sourceCode.getScope(node)
41+
: context.getScope();
42+
43+
const tracker = new ReferenceTracker(scope);
3644
const traceMap = {
3745
asyncTest: { [ReferenceTracker.CALL]: true },
3846
module: { [ReferenceTracker.CALL]: true },

lib/rules/no-global-stop-start.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,16 @@ module.exports = {
3333
//--------------------------------------------------------------------------
3434

3535
return {
36-
Program: function () {
37-
const tracker = new ReferenceTracker(context.getScope());
36+
Program: function (node) {
37+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
38+
const sourceCode =
39+
context.sourceCode ?? context.getSourceCode();
40+
/* istanbul ignore next: deprecated code paths only followed by old eslint versions */
41+
const scope = sourceCode.getScope
42+
? sourceCode.getScope(node)
43+
: context.getScope();
44+
45+
const tracker = new ReferenceTracker(scope);
3846
const traceMap = {
3947
start: { [ReferenceTracker.CALL]: true },
4048
stop: { [ReferenceTracker.CALL]: true },

0 commit comments

Comments
 (0)