Skip to content

Commit 4255f95

Browse files
committed
Tests: Fix bad test case that always passes
Follows-up #1335, which was missing the quotes on the tap-outputs key, and thus the unit test was seeing expectedOutput[command] as `undefined`, which was then passed to RegExp as `new RegExp(undefined)`, which produces /(?:)/, which is a no-op that always matches, so re.test(output) === true. Yay me for writing a useless test. Ref #1333.
1 parent 681cee7 commit 4255f95

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/cli/fixtures/expected/tap-outputs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ ok 2 Second > 1
5252
# todo 0
5353
# fail 0`,
5454

55-
"qunit 'fail/throws-match.js'":
55+
"qunit fail/throws-match.js":
5656
`TAP version 13
5757
not ok 1 global failure
5858
---

0 commit comments

Comments
 (0)