Skip to content

Add frame header bytes to MP3 score #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phw merged 2 commits into from
Mar 22, 2023
Merged

Add frame header bytes to MP3 score #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0782562
Add frame header format to MP3 score
Cephian Mar 16, 2023
7c1e706
add test mp3 with no tags
Cephian Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mutagen/mp3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,11 @@ def mime(self):
def score(filename, fileobj, header_data):
filename = filename.lower()

return (header_data.startswith(b"ID3") * 2 +
return ((header_data.startswith(b"ID3") or
header_data.startswith(b'\xFF\xF2') or
header_data.startswith(b'\xFF\xF3') or
header_data.startswith(b'\xFF\xFA') or
header_data.startswith(b'\xFF\xFB')) * 2 +
endswith(filename, b".mp3") +
endswith(filename, b".mp2") + endswith(filename, b".mpg") +
endswith(filename, b".mpeg"))
Expand Down
Binary file added tests/data/no-tags.mp3
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions tests/test___init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,7 @@ def test_dict(self):
os.path.join(DATA_DIR, "bad-xing.mp3"),
os.path.join(DATA_DIR, "xing.mp3"),
os.path.join(DATA_DIR, "silence-44-s.mp3"),
os.path.join(DATA_DIR, "no-tags.mp3"),
],
Musepack: [
os.path.join(DATA_DIR, "click.mpc"),
Expand Down