Proposal: Improve Test Coverage Infrastructure

[ksalhab89]

Assalamu Alaikum,

I'm a new contributor interested in helping improve the test coverage for this project. After exploring the codebase, I noticed there's an opportunity to strengthen the testing foundation, which could help prevent regressions and make future contributions safer.

Current State

• ~24 test files primarily in the app module
• No code coverage tooling configured
• Limited shared test utilities

Proposal

I'd like to contribute a testing infrastructure improvement in phases:

Phase 1: Foundation (Ready)

• Add Kover plugin for code coverage reporting
• Create common:test-utils module with shared test infrastructure:
  • TestDispatcherRule for coroutines testing
  • RxSchedulerRule for RxJava testing
  • Flow test extensions (Turbine-based)
  • TestDataFactory for Quran-specific test fixtures
• Expand QuranInfo tests from 6 to 46 tests (boundary conditions, invalid inputs, edge cases)

Future Phases (if Phase 1 is welcomed)

• Phase 2: Model layer tests (SuraAyah, bookmarks)
• Phase 3: Repository/data layer tests
• Phase 4: Presenter/ViewModel tests
• Phase 5: Integration tests

Why This Approach

1. Non-breaking: No changes to production code
2. Incremental: Small, reviewable PRs
3. Foundation-first: Utilities that make future testing easier
4. Follows existing patterns: Matches project's code style and architecture

Questions for Maintainers

Before I submit a PR, I wanted to check:

1. Is improving test coverage something you'd welcome?
2. Any preferences on testing frameworks? (I used JUnit4, Truth, MockK, Turbine based on existing tests)
3. Should the test-utils module live under common/ or elsewhere?
4. Any specific areas you'd prioritize for testing?

I have Phase 1 ready locally and can submit a PR whenever you're ready to review. Happy to adjust the approach based on your feedback.

JazakAllahu Khairan for maintaining this beautiful project.

[ahmedre]

wa3laikum alsalam wa ra7matullah,
jazakumAllah khairan, sure, really appreciate this!

1. definitely support improving test coverage (not sure about measuring it right now but not against it either so would accept Kover).
2. frameworks, junit4/turbine sound good - I want to eventually get rid of mockk and to favor fakes over mocks.
3. common sounds good for test-utils.
4. nothing specific but I guess audio, search, and bookmarks because those are some of the areas that have some planned changes.

jazakumAllah khairan and looking forward to your pr.
walsalam 3alaikum

[ksalhab89]

PR is now open: #3520

Implemented Phase 1 with the following based on your feedback:

• ✅ Fakes over mocks (removed MockK)
• ✅ Kover for code coverage
• ✅ Shared test-utils module with TestDataFactory, RxSchedulerRule, etc.
• ✅ Fixed pre-existing broken tests in audio modules
• ✅ Added comprehensive tests for QuranInfo

Ready for review when you have time. Thanks!