Refactor trigger property logic to avoid self.trigger = self.trigger#168
Open
Refactor trigger property logic to avoid self.trigger = self.trigger#168
self.trigger = self.trigger#168Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 22.26% 22.12% -0.14%
==========================================
Files 38 38
Lines 4703 4691 -12
==========================================
- Hits 1047 1038 -9
+ Misses 3656 3653 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test Results 4 files ±0 4 suites ±0 12s ⏱️ +2s For more details on these failures, see this check. Results for commit 3a15433. ± Comparison against base commit 6f1694a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not optimal because as the pre-existing TODO states, we should inform the user if we override the settings. But it reduces the abuse of property update logic.