add codereview suggestions

Author: Fe-r-oz

ext/QuantumToolboxMakieExt.jl

@@ -782,20 +782,6 @@ function _plot_vectors!(b::Bloch, ax)
     end
 end
 
-function _tolatex(s)
-    s == "x" && return L"\textbf{x}"
-    s == "y" && return L"\textbf{y}"
-    s == "z" && return L"\textbf{z}"
-    s == "-x" && return L"\textbf{-x}"
-    s == "-y" && return L"\textbf{-y}"
-    s == "-z" && return L"\textbf{-z}"
-    s == "|0⟩" && return L"\mathbf{|0\rangle}"
-    s == "|1⟩" && return L"\mathbf{|1\rangle}"
-    return s
-end
-
-_lerp(a::Float64, b::Float64, t::Float64) = a + t * (b - a)
-
 raw"""
     _add_labels!(ax)
 
@@ -809,71 +795,64 @@ Positions standard labels `(x, y, |0⟩, |1⟩)` at appropriate locations.
 function _add_labels!(b::Bloch, ax)
     label_color = parse(RGBf, b.font_color)
     label_size = b.font_size
-    label_font = b.font_name
     offset_scale = b.frame_limit
     if !isempty(b.xlabel) && !isempty(b.xlabel[1])
         text!(
             ax,
-            _tolatex(b.xlabel[1]),
+            L"\textbf{x}",
             position = Point3f(0, -offset_scale * b.xlpos[1], 0),
             color = label_color,
             fontsize = label_size,
-            font = label_font,
             align = (:center, :center)
         )
     end
     if length(b.xlabel) > 1 && !isempty(b.xlabel[2])
         text!(
             ax,
-            _tolatex(b.xlabel[2]),
+            L"\textbf{-x}",
             position = Point3f(0, -offset_scale * b.xlpos[2], 0),
             color = label_color,
             fontsize = label_size,
-            font = label_font,
             align = (:center, :center)
         )
     end
     if !isempty(b.ylabel) && !isempty(b.ylabel[1])
         text!(
             ax,
-            _tolatex(b.ylabel[1]),
+            L"\textbf{y}",
             position = Point3f(offset_scale * b.ylpos[1], 0, 0),
             color = label_color,
             fontsize = label_size,
-            font = label_font,
             align = (:center, :center)
         )
     end
     if length(b.ylabel) > 1 && !isempty(b.ylabel[2])
         text!(
             ax,
-            _tolatex(b.ylabel[2]),
+            L"\textbf{-y}",
             position = Point3f(offset_scale * b.ylpos[2], 0, 0),
             color = label_color,
             fontsize = label_size,
-            font = label_font,
             align = (:center, :center)
         )
     end
     if !isempty(b.zlabel) && !isempty(b.zlabel[1])
         text!(
             ax,
-            _tolatex(b.zlabel[1]),
+            L"\mathbf{|0\rangle}",
             position = Point3f(0, 0, offset_scale * b.zlpos[1]),
             color = label_color,
             fontsize = label_size,
-            font = label_font,
             align = (:center, :center)
         )
     end
     if length(b.zlabel) > 1 && !isempty(b.zlabel[2])
         text!(
             ax,
-            _tolatex(b.zlabel[2]),
+            L"\mathbf{|1\rangle}",
             position = Point3f(0, 0, offset_scale * b.zlpos[2]),
             color = label_color,
             fontsize = label_size,
-            font = label_font,
             align = (:center, :center)
         )
     end

src/visualization.jl

@@ -89,7 +89,6 @@ A structure representing a Bloch sphere visualization for quantum states.
 
 - `font_color::String`: Color of axis labels and text
 - `font_size::Int`: Font size for labels (default: 18)
-- `font_name::String`: Font family name (default: "TeX Gyre Heros")
 - `frame_alpha::Float64`: Transparency of the frame background
 - `frame_color::String`: Background color of the frame
 - `frame_limit::Float64`: Axis limits for the 3D frame (symmetric around origin)
@@ -133,7 +132,6 @@ A structure representing a Bloch sphere visualization for quantum states.
     arcs::Vector{Vector{Vector{Float64}}} = Vector{Vector{Vector{Float64}}}()
     font_color::String = "#333333"
     font_size::Int = 15
-    font_name::String = "Ariel"
     frame_alpha::Float64 = 0.0
     frame_color::String = "white"
     frame_limit::Float64 = 1.13
@@ -149,11 +147,11 @@ A structure representing a Bloch sphere visualization for quantum states.
     vector_width::Float64 = 0.025
     vector_arrowsize::NTuple{3,Real} = (0.07, 0.08, 0.08)
     view_angles::Tuple{Int,Int} = (-60, 30)
-    xlabel::Vector{String} = ["x", ""]
+    xlabel::Vector{AbstractString} = ["x", ""]
     xlpos::Vector{Float64} = [1.0, -1.0]
-    ylabel::Vector{String} = ["y", ""]
+    ylabel::Vector{AbstractString} = ["y", ""]
     ylpos::Vector{Float64} = [1.0, -1.0]
-    zlabel::Vector{String} = ["|0⟩", "|1⟩"]
+    zlabel::Vector{AbstractString} = ["|0⟩", "|1⟩"]
     zlpos::Vector{Float64} = [1.0, -1.0]
 end