fix type instability

Author: ytdHuang

src/qobj/superoperators.jl

@@ -166,18 +166,16 @@ function liouvillian(
 ) where {DT,OpType<:Union{OperatorQuantumObject,SuperOperatorQuantumObject}}
     L = liouvillian(H, Id_cache)
     if !(c_ops isa Nothing)
-        c_ops_tuple = Tuple(c_ops) # we must convert it to a tuple, so filter below also return tuple
-
         # sum all the (time-independent) c_ops first
-        c_ops_ti = filter(op -> isa(op, QuantumObject), c_ops_tuple)
+        c_ops_ti = filter(op -> isa(op, QuantumObject), c_ops)
         if !isempty(c_ops_ti)
             L += mapreduce(op -> lindblad_dissipator(op, Id_cache), +, c_ops_ti)
         end
 
         # sum rest of the QobjEvo together
-        c_ops_td = filter(op -> isa(op, QuantumObjectEvolution), c_ops_tuple)
+        c_ops_td = filter(op -> isa(op, QuantumObjectEvolution), c_ops)
         if !isempty(c_ops_td)
-            L += AddedOperator(map(op -> lindblad_dissipator(op, Id_cache), c_ops_td)) # it becomes AddedOperator at the end anyway
+            L += mapreduce(op -> lindblad_dissipator(op, Id_cache), +, c_ops_td)
         end
     end
     return L

test/core-test/quantum_objects_evo.jl

@@ -215,8 +215,8 @@
         @testset "Type Inference" begin
             H_td2 = H_td + QobjEvo(a + a', coef3)
 
-            # we use destroy and create here because it somehow might cause type instability
-            c_ops1 = (destroy(N), create(N)) 
+            # we use destroy and create here because they somehow causes type instability before
+            c_ops1 = (destroy(N), create(N))
             c_ops2 = (destroy(N), QobjEvo(create(N), coef1))
 
             @inferred liouvillian(H_td, c_ops1)