Skip to content

Commit 3f6d8ed

Browse files
authored
Fix Makie warning message (#528)
1 parent 252e362 commit 3f6d8ed

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

ext/QuantumToolboxMakieExt.jl

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@ import Makie:
2424
scatter!,
2525
arrows3d!,
2626
text!,
27-
Point3f,
2827
mesh!,
2928
RGBf,
30-
Vec3f,
3129
Point3f,
3230
NoShading,
3331
cameracontrols,
@@ -660,7 +658,7 @@ function _plot_arcs!(b::Bloch, lscene)
660658
dot(cross(v1, vm), n) < 0 &&-= 2π)
661659
end
662660
t_range = range(0, θ, length = 100)
663-
arc_points = [Point3f((v1 * cos(t) + cross(n, v1) * sin(t))) for t in t_range]
661+
arc_points = [Point3f(v1 * cos(t) + cross(n, v1) * sin(t)) for t in t_range]
664662
lines!(lscene, arc_points; color = "blue", linestyle = :solid)
665663
end
666664
return nothing
@@ -685,13 +683,13 @@ function _plot_vectors!(b::Bloch, lscene)
685683

686684
arrows3d!(
687685
lscene,
688-
[Point3f(0, 0, 0)],
689-
[v],
686+
Point3f(0),
687+
Point3f(v),
690688
color = color,
691689
shaftradius = b.vector_width,
692690
tiplength = b.vector_tiplength,
693691
tipradius = b.vector_tipradius,
694-
rasterize = 3,
692+
# rasterize = 3, #TODO: maybe uncomment this after https://github.com/MakieOrg/Makie.jl/issues/5259 is fixed
695693
)
696694
end
697695
return nothing

0 commit comments

Comments
 (0)