Minor changes

Author: albertomercurio

src/qobj/dimensions.jl

@@ -65,7 +65,7 @@ function GeneralProductDimensions(dims::Union{AbstractVector{T},NTuple{N,T}}) wh
 end
 
 _gen_dimensions(dims::AbstractDimensions) = dims
-_gen_dimensions(dims::Union{AbstractVector{T},NTuple{N,T}}) where {T<:Integer,N} = ProductDimensions(dims)
+_gen_dimensions(dims::Union{AbstractVector{<:Integer},NTuple{N,Integer}}) where {N} = ProductDimensions(dims)
 _gen_dimensions(dims::Union{AbstractVector{T},NTuple{N,T}}) where {T<:Union{AbstractVector,NTuple},N} =
     GeneralProductDimensions(dims)
 _gen_dimensions(dims::Any) = ProductDimensions(dims)

src/qobj/energy_restricted.jl

@@ -70,7 +70,7 @@ function Base.show(io::IO, s::EnrSpace)
     return nothing
 end
 
-Base.length(s::EnrSpace{N}) where {N} = N
+Base.length(::EnrSpace{N}) where {N} = N
 
 Base.:(==)(s_enr1::EnrSpace, s_enr2::EnrSpace) = (s_enr1.size == s_enr2.size) && (s_enr1.dims == s_enr2.dims)
 

src/qobj/quantum_object_base.jl

@@ -222,26 +222,22 @@ end
 
 # this returns `to` in GeneralProductDimensions representation
 get_dimensions_to(A::AbstractQuantumObject{Ket,<:ProductDimensions}) = A.dimensions.to
-get_dimensions_to(A::AbstractQuantumObject{Bra,<:ProductDimensions}) = space_one_list(A.dimensions.to)
+get_dimensions_to(A::AbstractQuantumObject{Bra,<:ProductDimensions}) = hilbertspace_one_list(A.dimensions.to)
 get_dimensions_to(A::AbstractQuantumObject{Operator,<:ProductDimensions}) = A.dimensions.to
 get_dimensions_to(A::AbstractQuantumObject{Operator,<:GeneralProductDimensions}) = A.dimensions.to
 get_dimensions_to(
     A::AbstractQuantumObject{ObjType,<:ProductDimensions},
 ) where {ObjType<:Union{SuperOperator,OperatorBra,OperatorKet}} = A.dimensions.to
 
 # this returns `from` in GeneralProductDimensions representation
-get_dimensions_from(A::AbstractQuantumObject{Ket,<:ProductDimensions}) = space_one_list(A.dimensions.to)
+get_dimensions_from(A::AbstractQuantumObject{Ket,<:ProductDimensions}) = hilbertspace_one_list(A.dimensions.to)
 get_dimensions_from(A::AbstractQuantumObject{Bra,<:ProductDimensions}) = A.dimensions.to
 get_dimensions_from(A::AbstractQuantumObject{Operator,<:ProductDimensions}) = A.dimensions.to
 get_dimensions_from(A::AbstractQuantumObject{Operator,<:GeneralProductDimensions}) = A.dimensions.from
 get_dimensions_from(
     A::AbstractQuantumObject{ObjType,<:ProductDimensions},
 ) where {ObjType<:Union{SuperOperator,OperatorBra,OperatorKet}} = A.dimensions.to
 
-# this creates a list of HilbertSpace(1), it is used to generate `from` for Ket, and `to` for Bra
-space_one_list(dimensions::NTuple{N,AbstractSpace}) where {N} =
-    ntuple(i -> HilbertSpace(1), Val(sum(length, dimensions)))
-
 # functions for getting Float or Complex element type
 _float_type(A::AbstractQuantumObject) = _float_type(eltype(A))
 _complex_float_type(A::AbstractQuantumObject) = _complex_float_type(eltype(A))

src/qobj/space.jl

@@ -25,3 +25,7 @@ end
 Base.length(s::HilbertSpace) = 1
 
 dimensions_to_dims(s::HilbertSpace) = SVector{1,Int}(s.size)
+
+# this creates a list of HilbertSpace(1), it is used to generate `from` for Ket, and `to` for Bra
+hilbertspace_one_list(dimensions::NTuple{N,AbstractSpace}) where {N} =
+    ntuple(i -> HilbertSpace(1), Val(sum(length, dimensions)))