Skip to content

Conversation

@albertomercurio
Copy link
Member

Description

I change the name of the MultiSiteOperator function to multisite_operator, since functions are always lower case here. Only structs can have upper case names.

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.68%. Comparing base (2b6e0d6) to head (f0ff205).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/deprecated.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   93.71%   93.68%   -0.04%     
==========================================
  Files          45       45              
  Lines        2896     2897       +1     
==========================================
  Hits         2714     2714              
- Misses        182      183       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be even easier to just name it as multisite (without _operator)?

@albertomercurio
Copy link
Member Author

It can be misleading as ve could also have in the future the equivalent of multisite state

@ytdHuang
Copy link
Member

It can be misleading as ve could also have in the future the equivalent of multisite state

ok, I see

@albertomercurio albertomercurio merged commit c984f95 into qutip:main Feb 11, 2025
14 of 17 checks passed
@albertomercurio albertomercurio mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants