Skip to content

Conversation

@albertomercurio
Copy link
Member

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

This PR improves the generation of the ensemble problem for ssesolve. Moreover, the stochastic processes were still using the old structure of parameters using NamedTuple. I changed it to be totally generic, with the NullParameters default value.

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.06%. Comparing base (0ce0b45) to head (c56efc1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/time_evolution/time_evolution.jl 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   93.65%   94.06%   +0.40%     
==========================================
  Files          45       45              
  Lines        2899     2862      -37     
==========================================
- Hits         2715     2692      -23     
+ Misses        184      170      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit dff6aa1 into qutip:main Feb 13, 2025
17 checks passed
@albertomercurio albertomercurio mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants