Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Feb 17, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

The current implementation of the save callbacks relies on PresetTimeCallback, which adds tstops to the integrator and can lead to extra, unnecessary evaluations of the differential equation. By contrast, using FunctionCallingCallback avoids adding tstops; it simply interpolates the solution at the desired time points.

This approach also resolves the issue where the solution’s stability depends on whether the e_ops argument is used.

We still need to wait this PR to be merged if we want type stability.

@albertomercurio albertomercurio marked this pull request as ready for review February 17, 2025 16:25
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.20%. Comparing base (d48371c) to head (51225c4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ution/callback_helpers/mesolve_callback_helpers.jl 80.00% 1 Missing ⚠️
...ution/callback_helpers/sesolve_callback_helpers.jl 75.00% 1 Missing ⚠️
...tion/callback_helpers/smesolve_callback_helpers.jl 75.00% 1 Missing ⚠️
...tion/callback_helpers/ssesolve_callback_helpers.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          46       46           
  Lines        2918     2918           
=======================================
  Hits         2749     2749           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang merged commit 300fd5d into qutip:main Feb 18, 2025
16 of 17 checks passed
albertomercurio added a commit to albertomercurio/QuantumToolbox.jl that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants