Skip to content

Conversation

@TendonFFF
Copy link
Collaborator

@TendonFFF TendonFFF commented Mar 7, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Move _change_eltype in CUDA extension to utilities.jl and rename it as _convert_eltype_wordsize

@TendonFFF TendonFFF marked this pull request as ready for review March 7, 2025 07:07
@TendonFFF TendonFFF added the Skip ChangeLog Skip changelog update check in PR label Mar 7, 2025
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (e76fcbe) to head (a028c37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          47       47           
  Lines        2998     2998           
=======================================
  Hits         2830     2830           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ytdHuang ytdHuang merged commit e22908f into qutip:main Mar 7, 2025
24 of 25 checks passed
@TendonFFF TendonFFF deleted the dev/eltype branch March 8, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip ChangeLog Skip changelog update check in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants