Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Jul 15, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

In this PR, we store both times and times_states in time evolution solutions.

Here are the new definitions:

  • times: List of time points which is same as user-specified tlist (corresponding to sol.expect)
  • times_states: List of time points which is same as SciML sol.t (corresponding to sol.states)

Related issues or PRs

fix #504

@ytdHuang ytdHuang marked this pull request as ready for review July 15, 2025 16:41
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (3057e3e) to head (d0bb36d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          51       51           
  Lines        3513     3513           
=======================================
  Hits         3304     3304           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ytdHuang ytdHuang requested a review from albertomercurio July 15, 2025 17:06
@ytdHuang ytdHuang changed the title Store both tlist and times in time evolution solutions Store both times and times_states in time evolution solutions Jul 21, 2025
@albertomercurio albertomercurio merged commit 5e1707d into qutip:main Jul 22, 2025
18 checks passed
@ytdHuang ytdHuang deleted the fix/sol-times branch July 22, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatch between times and states in sesolve with callbacks

2 participants