Improve accuracy of ODE solvers for general cases #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR need to wait for PR #581 to be merged first. |
ytdHuang
force-pushed
the
improve-ODE
branch
from
ace8a23 to
d661452
Compare
Member
|
The tests are failing |
ytdHuang
force-pushed
the
improve-ODE
branch
from
edfebcd to
e5f04cf
Compare
Member
Author
|
Ok, errors fixed. The benchmarks show that |
albertomercurio
approved these changes
Nov 16, 2025
Member
albertomercurio
left a comment
albertomercurio
left a comment
There was a problem hiding this comment.
LGTM!
I would add some tests that check that tstops are indeed not generated when the propagator is constant. Just to be sure.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 553f6ed | Previous: c0270e7 | Ratio |
|---|---|---|---|
Autodiff/sesolve/Reverse (Enzyme) |
412546417 ns |
309461206 ns |
1.33 |
Time Evolution/time-independent/sesolve |
2552871 ns |
1737074.5 ns |
1.47 |
Time Evolution/time-dependent/sesolve/QobjEvo |
62704184 ns |
47184340 ns |
1.33 |
Time Evolution/time-dependent/sesolve/Tuple |
62721466 ns |
47102182.5 ns |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
The changes in this PR:
sesolvedefault algorithm toVern7(lazy=false)mesolveandmcsolveand other related solver default algorithm toDP5tstopsfor all ODE solvers if the problem is time-dependent.