Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Nov 29, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

As title

@ytdHuang ytdHuang added the Skip ChangeLog Skip changelog update check in PR label Nov 29, 2024
@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (b314479) to head (18c8cb4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   93.19%   92.67%   -0.52%     
==========================================
  Files          36       36              
  Lines        2602     2595       -7     
==========================================
- Hits         2425     2405      -20     
- Misses        177      190      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit 9a9a80d into main Nov 29, 2024
15 of 18 checks passed
@ytdHuang ytdHuang deleted the ytdHuang-patch-2 branch November 29, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip ChangeLog Skip changelog update check in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants