Add more generic solver for steadystate_floquet #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertomercurio
force-pushed
the
dev/patch-2
branch
from
6ce4e9d to
f8b5bab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 93.67% 93.65% -0.02%
==========================================
Files 45 45
Lines 2892 2899 +7
==========================================
+ Hits 2709 2715 +6
- Misses 183 184 +1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
The 1.10 Ubuntu case is a random weird error, not related to this PR. Very weird though. |
Member
Author
|
Any comment on this? It is just an internal improvement. |
ytdHuang
approved these changes
Feb 13, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous solver for
liouvillian_floquetwas limited to only the GMRES method with predefined preconditioner. Here I make a more generic solver, by simply compying the implementation already done in thesteadystatefunction.