Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Feb 14, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

With this PR I introduce the support for the measurement on stochastic solvers like ssesolve and smesolve.

By doing so, I changed a bit the structure of the callback helpers.

I also changed the default number of trajectories for these solvers, in order to align with qutip. And I also changed the name of the ensemble_method argument to ensemblealg.

@albertomercurio albertomercurio marked this pull request as ready for review February 14, 2025 06:19
@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 97.16981% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.16%. Comparing base (81724ad) to head (d7d29ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ime_evolution/callback_helpers/callback_helpers.jl 97.56% 1 Missing ⚠️
...tion/callback_helpers/smesolve_callback_helpers.jl 93.75% 1 Missing ⚠️
...tion/callback_helpers/ssesolve_callback_helpers.jl 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   94.06%   94.16%   +0.10%     
==========================================
  Files          45       46       +1     
  Lines        2862     2898      +36     
==========================================
+ Hits         2692     2729      +37     
+ Misses        170      169       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit 49e9ffc into qutip:main Feb 14, 2025
17 checks passed
@albertomercurio albertomercurio mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants