Skip to content

Commit 57c2a84

Browse files
committed
added roadmap
1 parent 447cb54 commit 57c2a84

File tree

9 files changed

+17
-11
lines changed

9 files changed

+17
-11
lines changed

README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,15 @@ npm install -D qwik-nx
88

99
## Usage
1010

11+
### Generating an Application
1112
```
1213
nx generate qwik-nx:app
13-
1414
```
1515

16-
TBD
16+
## ROADMAP:
17+
18+
* [ ] Complete generators for Route, Component and more
19+
* [ ] Complete `add-nx-to-qwik` and `create-qwik-nx`
20+
* [ ] Writing missing tests
21+
* [ ] Move package.json scripts to project.json targets
22+
* [ ] more...

e2e/qwik-nx-e2e/tests/qwik-nx.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('qwik-nx e2e', () => {
2525

2626
it('should create qwik-nx', async () => {
2727
const project = uniq('qwik-nx');
28-
await runNxCommandAsync(`generate qwik-nx:qwik-nx ${project}`);
28+
await runNxCommandAsync(`generate qwik-nx:app ${project}`);
2929
const result = await runNxCommandAsync(`build ${project}`);
3030
expect(result.stdout).toContain('Executor ran');
3131
}, 120000);
@@ -34,7 +34,7 @@ describe('qwik-nx e2e', () => {
3434
it('should create src in the specified directory', async () => {
3535
const project = uniq('qwik-nx');
3636
await runNxCommandAsync(
37-
`generate qwik-nx:qwik-nx ${project} --directory subdir`
37+
`generate qwik-nx:app ${project} --directory subdir`
3838
);
3939
expect(() =>
4040
checkFilesExist(`libs/subdir/${project}/src/index.ts`)
@@ -47,7 +47,7 @@ describe('qwik-nx e2e', () => {
4747
const projectName = uniq('qwik-nx');
4848
ensureNxProject('qwik-nx', 'dist/packages/qwik-nx');
4949
await runNxCommandAsync(
50-
`generate qwik-nx:qwik-nx ${projectName} --tags e2etag,e2ePackage`
50+
`generate qwik-nx:app ${projectName} --tags e2etag,e2ePackage`
5151
);
5252
const project = readJson(`libs/${projectName}/project.json`);
5353
expect(project.tags).toEqual(['e2etag', 'e2ePackage']);

packages/add-nx-to-qwik/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "add-nx-to-qwik",
3-
"version": "0.0.1",
3+
"version": "0.0.0",
44
"private": false,
55
"description": "Make qwik build even faster by adding Nx to it",
66
"repository": {

packages/add-nx-to-qwik/tsconfig.lib.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
"sourceMap": false
1010
},
1111
"exclude": ["**/*.spec.ts", "jest.config.ts"],
12-
"include": ["**/*.ts"]
12+
"include": ["**/*.ts", "src/tbd.js"]
1313
}

packages/create-qwik-nx/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"bin": {
1919
"create-qwik-nx": "./bin/tbd.js"
2020
},
21-
"author": "Victor Savkin",
21+
"author": "Shai Reznik",
2222
"license": "MIT",
2323
"bugs": {
2424
"url": "https://github.com/qwikifiers/qwik-nx/issues"

packages/create-qwik-nx/tsconfig.lib.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@
1313
"**/*_test.ts",
1414
"jest.config.ts"
1515
],
16-
"include": ["**/*.ts", "package.json"]
16+
"include": ["**/*.ts", "package.json", "bin/tbd.חs"]
1717
}

packages/qwik-nx/src/generators/component/generator.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function normalizeOptions(tree: Tree, options: ComponentGeneratorSchema): Normal
3737
};
3838
}
3939

40-
function addFiles(tree: Tree, options: NormalizedSchema) {
40+
function createComponentFiles(tree: Tree, options: NormalizedSchema) {
4141
const templateOptions = {
4242
...options,
4343
...names(options.name),
@@ -64,6 +64,6 @@ export default async function (tree: Tree, options: ComponentGeneratorSchema) {
6464
tags: normalizedOptions.parsedTags,
6565
}
6666
);
67-
addFiles(tree, normalizedOptions);
67+
createComponentFiles(tree, normalizedOptions);
6868
await formatFiles(tree);
6969
}

0 commit comments

Comments
 (0)