Skip to content

Commit b88255a

Browse files
refactor(qwik-nx): minor fixes
1 parent b013739 commit b88255a

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

e2e/qwik-nx-e2e/tests/chore.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ describe('misc checks', () => {
2323
expect(packageJson.dependencies).toBeUndefined();
2424
expect(packageJson.devDependencies).toBeUndefined();
2525
expect(packageJson.peerDependencies).toEqual({
26-
'@nx/devkit': '^20.0.0',
27-
'@nx/js': '^20.0.0',
28-
'@nx/eslint': '^20.0.0',
29-
'@nx/vite': '^20.0.0',
26+
'@nx/devkit': '^20.7.0',
27+
'@nx/js': '^20.7.0',
28+
'@nx/eslint': '^20.7.0',
29+
'@nx/vite': '^20.7.0',
3030
});
3131
},
3232
DEFAULT_E2E_TIMEOUT

packages/qwik-nx/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
"generators": "./generators.json",
2323
"executors": "./executors.json",
2424
"peerDependencies": {
25-
"@nx/devkit": "^20.0.0",
26-
"@nx/js": "^20.0.0",
27-
"@nx/vite": "^20.0.0",
28-
"@nx/eslint": "^20.0.0"
25+
"@nx/devkit": "^20.7.0",
26+
"@nx/js": "^20.7.0",
27+
"@nx/vite": "^20.7.0",
28+
"@nx/eslint": "^20.7.0"
2929
},
3030
"nx-migrations": {
3131
"migrations": "./migrations.json"

packages/qwik-nx/src/generators/application/utils/normalize-options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export async function normalizeOptions(
3434

3535
return {
3636
...options,
37-
name: options.name!, // defined by "ensureProjectName"
37+
name: options.name ?? appProjectName,
3838
projectName: appProjectName,
3939
projectRoot: appProjectRoot,
4040
offsetFromRoot: offsetFromRoot(appProjectRoot),

packages/qwik-nx/src/generators/component/utils/normalize-options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function normalizeNameAndPaths(
3535
);
3636

3737
const projectSourceRoot = sourceRoot ?? joinPathFragments(root, 'src');
38-
const componentName = options.name || 'component';
38+
const componentName = options.name;
3939
const { name, path: namePath } = parseNameWithPath(componentName);
4040

4141
const path =

packages/qwik-nx/src/generators/library/utils/normalize-options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export async function normalizeOptions(
3737

3838
return {
3939
...withDefaultValues,
40-
name: schema.name!, // defined by the "ensureProjectName"
40+
name: schema.name ?? projectName,
4141
projectName,
4242
projectRoot,
4343
parsedTags,

0 commit comments

Comments
 (0)