refactor(repo): eslint updates

Author: dmitry-stepanenko

.eslintrc.json

@@ -30,7 +30,7 @@
         "@typescript-eslint/no-non-null-assertion": "off",
         "unused-imports/no-unused-imports": "error",
         "no-duplicate-imports": "error",
-        "unused-imports/no-unused-vars": "error",
+        "@typescript-eslint/no-unused-vars": "error",
         "@typescript-eslint/naming-convention": [
           "error",
           {
@@ -42,16 +42,14 @@
             "format": ["PascalCase"]
           }
         ],
-        "@typescript-eslint/no-extra-semi": "error",
-        "no-extra-semi": "off"
+        "no-extra-semi": "error"
       }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
       "rules": {
-        "@typescript-eslint/no-extra-semi": "error",
-        "no-extra-semi": "off"
+        "no-extra-semi": "error"
       }
     },
     {

.github/actions/test/action.yml

@@ -20,7 +20,7 @@ runs:
 
     - name: Test
       shell: bash
-      run: npx nx affected --target=test --base=${{ env.NX_BASE }} --head=HEAD
+      run: npx nx affected --target=test --base=${{ env.NX_BASE }} --head=HEAD ${{ runner.os == 'Windows' && '--maxWorkers=1' }}
 
     - name: E2E Tests
       # TODO: temporary disabled e2e on windows

package.json

@@ -44,9 +44,9 @@
     "@types/semver": "7.5.6",
     "@types/tcp-port-used": "1.0.1",
     "@types/yargs": "17.0.24",
-    "@typescript-eslint/eslint-plugin": "7.18.0",
-    "@typescript-eslint/parser": "7.18.0",
-    "@typescript-eslint/utils": "^8.13.0",
+    "@typescript-eslint/eslint-plugin": "^8.19.1",
+    "@typescript-eslint/parser": "8.19.1",
+    "@typescript-eslint/utils": "^8.19.1",
     "all-contributors-cli": "^6.26.1",
     "chalk": "^4.1.2",
     "commitizen": "^4.3.0",
@@ -56,7 +56,7 @@
     "enquirer": "2.3.6",
     "eslint": "8.57.0",
     "eslint-config-prettier": "9.0.0",
-    "eslint-plugin-unused-imports": "2.0.0",
+    "eslint-plugin-unused-imports": "^4.1.4",
     "fs-extra": "11.1.0",
     "husky": "^8.0.3",
     "is-windows": "1.0.2",

packages/create-qwik-nx/bin/index.ts

@@ -2,4 +2,5 @@
 
 import { commandsObject } from './create-qwik-nx';
 
+// eslint-disable-next-line @typescript-eslint/no-unused-expressions
 commandsObject.argv;

packages/qwik-nx/src/generators/application/schema.d.ts

@@ -1,5 +1,4 @@
 import type { Linter } from '@nx/eslint';
-import type { ProjectNameAndRootFormat } from '@nx/devkit/src/generators/project-name-and-root-utils';
 
 export interface QwikAppGeneratorSchema {
   directory: string;

packages/qwik-nx/src/generators/host/generator.ts

@@ -12,7 +12,7 @@ import { HostGeneratorSchema } from './schema';
 import { appGenerator } from './../application/generator';
 import remoteGenerator from '../remote/generator';
 import { normalizeOptions } from '../application/utils/normalize-options';
-import { basename, dirname, join } from 'path';
+import { dirname, join } from 'path';
 import { addMicroFrontendBetaWarning } from '../../utils/mf-beta-warning';
 import { NormalizedSchema } from '../application/schema';
 

packages/qwik-nx/src/generators/remote/schema.d.ts

@@ -1,5 +1,3 @@
-import { ProjectNameAndRootFormat } from '@nx/devkit/src/generators/project-name-and-root-utils';
-
 export interface RemoteGeneratorSchema {
   name?: string;
   tags?: string;

packages/qwik-nx/src/generators/setup-tailwind/lib/add-tailwind-style-imports.ts

@@ -24,11 +24,12 @@ export function addTailwindStyleImports(
 
   if (stylesPath) {
     const content = tree.read(stylesPath)?.toString();
-    content &&
+    if (content) {
       tree.write(
         stylesPath,
         `@tailwind components;\n@tailwind base;\n@tailwind utilities;\n${content}`
       );
+    }
   } else {
     logger.warn(
       stripIndents`

packages/qwik-nx/src/migrations/add-root-property-to-vite-config.ts

@@ -7,7 +7,7 @@ import { updateViteConfig } from '../utils/update-vite-config';
 export default function update(host: Tree) {
   const projects = getProjects(host);
 
-  projects.forEach((config, name) => {
+  projects.forEach((config) => {
     if (isQwikNxProject(config)) {
       const viteConfigPath = normalizeViteConfigFilePathWithTree(
         host,

packages/qwik-nx/src/plugins/utils/get-vendor-roots.ts

@@ -16,8 +16,9 @@ export async function getVendorRoots(
   qwikOptions: QwikVitePluginOptionsStub
 ): Promise<string[]> {
   const log = (...str: unknown[]) => {
-    (options?.debug || qwikOptions.debug) &&
+    if (options?.debug || qwikOptions.debug) {
       console.debug(`[QWIK-NX-VITE PLUGIN:]`, ...str);
+    }
   };
 
   const workspaceConfig = readWorkspaceConfig({ format: 'nx' });