Skip to content

Commit 03925fa

Browse files
committed
refactor(navigation-docs): make <a> wrap <li> instead of <li> wrap <a>
this change improves the "click" behaviror. Because of current wrapping sequence, you must click on the text instead of the container to trigger url (container is <li>, text is <a>). Now, clicking on the container, or text, will trigger url (container is <a>, text is <li>)
1 parent 75df085 commit 03925fa

File tree

1 file changed

+13
-15
lines changed

1 file changed

+13
-15
lines changed

apps/website/src/components/navigation-docs/navigation-docs.tsx

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,33 +26,31 @@ export const DocsNavigation = component$(({ linksGroups }: DocsNavigationProps)
2626
const location = useLocation();
2727
const rootStore = useAppState();
2828
const selectedKitSig = useSelectedKit();
29-
const linkStyles = `px-4 py-2 -ml-4 mr-8 text-xl lg:text-sm flex items-center
29+
const linkStyles = `px-4 py-2 -ml-4 mr-8 text-xl lg:text-sm flex items-center
3030
rounded-lg hover:bg-[var(--qwik-light-blue)] dark:hover:bg-[var(--qwik-dark-purple)]`;
3131
return (
3232
<nav
3333
class={`bg-background fixed inset-0 top-20 z-10 flex-col gap-4 overflow-y-auto border-r-[1px] pb-6 [grid-area:nav] lg:w-80
3434
${rootStore.isSidebarOpened ? 'w-100 flex' : 'hidden lg:flex'} `}
3535
>
3636
<ul class="show mt-8 flex flex-col gap-2 pl-12 lg:hidden">
37-
<li class={linkStyles}>
38-
<a href="/about">About</a>
39-
</li>
37+
<a href="/about">
38+
<li class={linkStyles}>About</li>
39+
</a>
4040
{selectedKitSig.value !== KitName.HEADLESS && (
41-
<li class={linkStyles}>
42-
<a href="/docs/headless/introduction">Headless Kit</a>
43-
</li>
41+
<a href="/docs/headless/introduction">
42+
<li class={linkStyles}>Headless Kit</li>
43+
</a>
4444
)}
4545
{rootStore.featureFlags?.showFluffy &&
4646
selectedKitSig.value !== KitName.FLUFFY && (
47-
<li class={linkStyles}>
48-
<a href="/docs/fluffy/introduction">Styled Kit</a>
49-
</li>
47+
<a href="/docs/fluffy/introduction">
48+
<li class={linkStyles}>Styled Kit</li>
49+
</a>
5050
)}
51-
<li class={linkStyles}>
52-
<a href="https://discord.gg/PVWUUejrez" target="_blank">
53-
Community
54-
</a>
55-
</li>
51+
<a href="https://discord.gg/PVWUUejrez" target="_blank">
52+
<li class={linkStyles}>Community</li>
53+
</a>
5654
{/* <a href="/contact">Contact</a> */}
5755
</ul>
5856
{linksGroups?.map((group) => {

0 commit comments

Comments
 (0)