Skip to content

Commit 0e97e1b

Browse files
fix: content blocking aria-expanded and select visible after computed
1 parent 255a9ef commit 0e97e1b

File tree

1 file changed

+10
-4
lines changed
  • packages/kit-headless/src/components/select

1 file changed

+10
-4
lines changed

packages/kit-headless/src/components/select/select.tsx

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
useOnWindow,
1111
useStore,
1212
useVisibleTask$,
13+
QwikIntrinsicElements,
1314
} from '@builder.io/qwik';
1415
import { computePosition, flip } from '@floating-ui/dom';
1516

@@ -71,7 +72,11 @@ export const SelectRoot = component$(
7172
const expanded = track(() => isExpanded.value);
7273

7374
if (expanded && trigger && listBox) {
74-
updatePosition(trigger, listBox);
75+
listBox.style.visibility = 'hidden';
76+
77+
updatePosition(trigger, listBox).then(() => {
78+
listBox.style.visibility = 'visible';
79+
});
7580
}
7681

7782
if (expanded === false) {
@@ -113,9 +118,9 @@ export const SelectRoot = component$(
113118
}
114119
);
115120

116-
export interface TriggerProps extends StyleProps {
121+
export type TriggerProps = {
117122
disabled?: boolean;
118-
}
123+
} & QwikIntrinsicElements['button'];
119124

120125
export const SelectTrigger = component$(
121126
({ disabled, ...props }: TriggerProps) => {
@@ -128,7 +133,8 @@ export const SelectTrigger = component$(
128133
ref={ref}
129134
aria-expanded={contextService.isExpanded.value}
130135
disabled={disabled}
131-
onClick$={() => {
136+
onClick$={(e) => {
137+
e.stopPropagation();
132138
contextService.isExpanded.value = !contextService.isExpanded.value;
133139
}}
134140
onKeyDown$={(e) => {

0 commit comments

Comments
 (0)