Skip to content

Commit 173e226

Browse files
refactor(select): add select research
1 parent a76906c commit 173e226

File tree

3 files changed

+35
-2
lines changed

3 files changed

+35
-2
lines changed

apps/website/src/routes/docs/headless/select/examples/hero.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export default component$(() => {
1111
class="hidden"
1212
style={{ padding: '0px', margin: '0px', listStyle: 'none' }}
1313
>
14-
<SelectOption disabled>My option</SelectOption>
1514
{usersSig.value.map((user) => (
1615
<SelectOption key={user}>{user}</SelectOption>
1716
))}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
What do we absolutely need? I am talking about the bare minimum, but powerful functionality we need for a select component.
2+
3+
# Select Research
4+
5+
## Anatomy:
6+
7+
<Select>
8+
<SelectTrigger />
9+
<SelectPopover>
10+
<SelectListbox>
11+
<SelectOption>
12+
</SelectListbox>
13+
</SelectPopover>
14+
</Select>
15+
16+
## Props:
17+
18+
name: bind:selected
19+
type: Signal
20+
description: controlled selected value, manages the selected option.
21+
22+
name: defaultSelected
23+
type: boolean
24+
description: uncontrolled selected value, sets the initial selected option.
25+
26+
name: onSelectedChange$
27+
type: PropFunction
28+
description: Prop function called when the value changes.
29+
30+
name: multiple
31+
type: boolean
32+
description: used for multi-select
33+
34+
## Keyboard Interactions:

packages/kit-headless/src/components/select/select-trigger.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,11 @@ export const SelectTrigger = component$<SelectTriggerProps>((props) => {
164164
{...props}
165165
ref={context.triggerRef}
166166
onClick$={[handleClick$, props.onClick$]}
167-
aria-expanded={context.isListboxOpenSig.value}
168167
onKeyDown$={[handleKeyDownSync$, handleKeyDown$, props.onKeyDown$]}
169168
data-open={context.isListboxOpenSig.value ? '' : undefined}
170169
data-closed={!context.isListboxOpenSig.value ? '' : undefined}
171170
class="bg-slate-800 p-2 text-white"
171+
aria-expanded={context.isListboxOpenSig.value}
172172
>
173173
<Slot />
174174
{context.selectedOptionRef.value?.textContent}

0 commit comments

Comments
 (0)