Skip to content

Commit 3524202

Browse files
Merge pull request #692 from qwikifiers/changeset-release/main
Version Packages
2 parents e9ccb07 + 59279a6 commit 3524202

File tree

10 files changed

+203
-91
lines changed

10 files changed

+203
-91
lines changed

.changeset/eight-spiders-brake.md

Lines changed: 0 additions & 60 deletions
This file was deleted.

.changeset/mighty-snails-exist.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/tough-keys-rest.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.changeset/warm-pans-drum.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"yargs": "17.7.2"
1515
},
1616
"devDependencies": {
17-
"@qwik-ui/styled": "0.0.5"
17+
"@qwik-ui/styled": "0.0.6"
1818
},
1919
"type": "commonjs",
2020
"main": "./src/index.js",

packages/kit-headless/CHANGELOG.md

Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,72 @@
11
# Changelog
22

3+
## 0.3.6
4+
5+
### Patch Changes
6+
7+
- 🐞🩹 modal does not close unless the dialog backdrop is clicked (including dangling content) (by [@thejackshelton](https://github.com/thejackshelton) in [#702](https://github.com/qwikifiers/qwik-ui/pull/702))
8+
9+
fix: polyfilled popovers render correctly inside of modals.
10+
11+
fix: nested modals will now close the current modal when the backdrop is clicked.
12+
13+
fix: nested modals will now close the current modal when the escape key is pressed.
14+
15+
fix: select does not execute code until interaction (including core).
16+
17+
tests: larger test suite for modals.
18+
19+
deprecated: `ModalHeader`, `ModalContent`, `ModalFooter` have been deprecated, as they do not pose significant a11y advantages.
20+
21+
feat: Two new Modal component pieces. `ModalTitle` and `ModalDescription`. These help give our modal an accessible name and supporting description (optional).
22+
23+
feat: Modal now uses the following CSS as a default inside of an @layer
24+
25+
```css
26+
@layer qwik-ui {
27+
/* browsers automatically set an interesting max-width and max-height for dialogs
28+
https://twitter.com/t3dotgg/status/1774350919133691936
29+
*/
30+
dialog:modal {
31+
max-width: unset;
32+
max-height: unset;
33+
}
34+
}
35+
```
36+
37+
The default browser styles:
38+
39+
![alt text](image.png)
40+
41+
Make it difficult to style a dialog element full-screen, which has led to some confusion recently both in this repo and across the web. The above change strips the responsible browser styles from the dialog eleemnt (which is used by Qwik UI's modal component).
42+
43+
> For more info, feel free to check out the link in the code snippet above.
44+
45+
> Note: In the future, we intend to use the dot notation for the `Modal` component.
46+
47+
> Note: In the future, we intend to change the modal API to include a trigger. The proposed API is as follows:
48+
49+
### Syntax Proposal
50+
51+
```tsx
52+
<Modal.Root>
53+
<Modal.Trigger>Trigger</Modal.Trigger>
54+
<Modal.Panel>
55+
{/* This is the current <Modal /> */}
56+
<Modal.Title>Edit Profile</Modal.Title>
57+
<Modal.Description>You can update your profile here.</Modal.Description>
58+
</Modal.Panel>
59+
</Modal.Root>
60+
```
61+
62+
Let us know your thoughts on this potential API change in the Qwik UI discord!
63+
64+
- ✨ deprecate `modal-showing` and `modal-closing` classes in favor of `data-open`, `data-closing`, and `data-closed` data attributes. (by [@thejackshelton](https://github.com/thejackshelton) in [#702](https://github.com/qwikifiers/qwik-ui/pull/702))
65+
66+
> These classes will still work at the moment, but will be removed in a near future release.
67+
68+
- refactor: popover listbox class deprecated and set as a default when in floating mode. (by [@thejackshelton](https://github.com/thejackshelton) in [#691](https://github.com/qwikifiers/qwik-ui/pull/691))
69+
370
## 0.3.5
471

572
### Patch Changes

packages/kit-headless/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@qwik-ui/headless",
3-
"version": "0.3.5",
3+
"version": "0.3.6",
44
"description": "Qwik UI headless components library",
55
"publishConfig": {
66
"access": "public"

packages/kit-styled/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# @qwik-ui/styled
22

3+
## 0.0.6
4+
5+
### Patch Changes
6+
7+
- refactor change CardTitle font-weight to medium (by [@maiieul](https://github.com/maiieul) in [#693](https://github.com/qwikifiers/qwik-ui/pull/693))
8+
39
## 0.0.5
410

511
### Patch Changes

packages/kit-styled/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@qwik-ui/styled",
3-
"version": "0.0.5",
3+
"version": "0.0.6",
44
"description": "Qwik UI components library with styles",
55
"publishConfig": {
66
"access": "public"
@@ -18,7 +18,7 @@
1818
"@builder.io/qwik": "^1.1.0"
1919
},
2020
"devDependencies": {
21-
"@qwik-ui/headless": "0.3.5",
21+
"@qwik-ui/headless": "0.3.6",
2222
"@qwik-ui/utils": "0.2.1"
2323
}
2424
}

0 commit comments

Comments
 (0)