Skip to content

Commit 425e628

Browse files
reverted nx upgrade
Co-authored-by: Jack Shelton <[email protected]>
1 parent 15d20c5 commit 425e628

File tree

18 files changed

+1119
-847
lines changed

18 files changed

+1119
-847
lines changed

.env

Lines changed: 0 additions & 39 deletions
This file was deleted.

apps/website-e2e/project.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
},
2020
"lint": {
2121
"executor": "@nx/eslint:lint",
22-
"outputs": ["{options.outputFile}"]
22+
"outputs": ["{options.outputFile}"],
23+
"options": { "lintFilePatterns": ["apps/website-e2e/**/*.{js,ts}"] }
2324
}
2425
},
2526
"tags": [],

apps/website/.eslintrc.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"extends": [
3-
"plugin:playwright/recommended",
43
"../../.eslintrc.json",
54
"eslint:recommended",
65
"plugin:@typescript-eslint/recommended",
@@ -29,10 +28,6 @@
2928
{
3029
"files": ["*.js", "*.jsx"],
3130
"rules": {}
32-
},
33-
{
34-
"files": ["e2e/**/*.{ts,js,tsx,jsx}"],
35-
"rules": {}
3631
}
3732
]
3833
}

apps/website/e2e/example.spec.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

apps/website/playwright.config.ts

Lines changed: 0 additions & 70 deletions
This file was deleted.

apps/website/vite.config.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@ export default defineConfig(async () => {
1010
const { visit } = await import('unist-util-visit');
1111

1212
return {
13-
root: __dirname,
14-
build: {
15-
outDir: '../../dist/apps/website',
16-
reportCompressedSize: true,
17-
commonjsOptions: {
18-
transformMixedEsModules: true,
19-
},
20-
},
2113
plugins: [
2214
qwikNxVite(),
2315
qwikCity({

migrations.json

Lines changed: 35 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,41 +2,55 @@
22
"migrations": [
33
{
44
"cli": "nx",
5-
"version": "17.3.0-beta.6",
6-
"description": "Updates the nx wrapper.",
7-
"implementation": "./src/migrations/update-17-3-0/update-nxw",
5+
"version": "17.0.0-beta.1",
6+
"description": "Updates the default cache directory to .nx/cache",
7+
"implementation": "./src/migrations/update-17-0-0/move-cache-directory",
88
"package": "nx",
9-
"name": "17.3.0-update-nx-wrapper"
9+
"name": "17.0.0-move-cache-directory"
1010
},
1111
{
1212
"cli": "nx",
13-
"version": "18.0.0-beta.2",
14-
"description": "Updates .env to disabled adding plugins when generating projects in an existing Nx workspace",
15-
"implementation": "./src/migrations/update-18-0-0/disable-crystal-for-existing-workspaces",
16-
"x-repair-skip": true,
13+
"version": "17.0.0-beta.3",
14+
"description": "Use minimal config for tasksRunnerOptions",
15+
"implementation": "./src/migrations/update-17-0-0/use-minimal-config-for-tasks-runner-options",
1716
"package": "nx",
18-
"name": "18.0.0-disable-adding-plugins-for-existing-workspaces"
17+
"name": "17.0.0-use-minimal-config-for-tasks-runner-options"
1918
},
2019
{
21-
"version": "17.2.0-beta.10",
22-
"description": "Update vite config.",
23-
"implementation": "./src/migrations/update-17-2-0/update-vite-config",
20+
"version": "17.0.0-rc.1",
21+
"description": "Migration for v17.0.0-rc.1",
22+
"implementation": "./src/migrations/update-17-0-0/rm-default-collection-npm-scope",
23+
"package": "nx",
24+
"name": "rm-default-collection-npm-scope"
25+
},
26+
{
27+
"version": "17.1.0-beta.2",
28+
"description": "Move target defaults",
29+
"implementation": "./src/migrations/update-17-1-0/move-target-defaults",
2430
"package": "@nx/vite",
25-
"name": "update-vite-config"
31+
"name": "move-target-defaults"
32+
},
33+
{
34+
"cli": "nx",
35+
"version": "17.0.2",
36+
"description": "Remove deprecated build options",
37+
"implementation": "./src/migrations/update-17-0-0/remove-deprecated-build-options",
38+
"package": "@nx/js",
39+
"name": "update-17-0-0-remove-deprecated-build-options"
2640
},
2741
{
28-
"version": "17.2.0-beta.0",
29-
"description": "Simplify eslintFilePatterns",
30-
"implementation": "./src/migrations/update-17-2-0/simplify-eslint-patterns",
42+
"version": "17.0.0-beta.7",
43+
"description": "update-17-0-0-rename-to-eslint",
44+
"implementation": "./src/migrations/update-17-0-0-rename-to-eslint/update-17-0-0-rename-to-eslint",
3145
"package": "@nx/eslint",
32-
"name": "simplify-eslint-patterns"
46+
"name": "update-17-0-0-rename-to-eslint"
3347
},
3448
{
35-
"version": "17.2.9",
36-
"description": "Move executor options to target defaults",
37-
"implementation": "./src/migrations/update-17-2-9/move-options-to-target-defaults",
49+
"version": "17.1.0-beta.1",
50+
"description": "Updates for @typescript-utils/utils v6.9.1+",
51+
"implementation": "./src/migrations/update-17-1-0/update-typescript-eslint",
3852
"package": "@nx/eslint",
39-
"name": "move-options-to-target-defaults"
53+
"name": "update-typescript-eslint"
4054
}
4155
]
4256
}

nx.json

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,12 @@
1414
}
1515
}
1616
},
17-
"plugins": [
18-
{
19-
"plugin": "@nx/playwright/plugin",
20-
"options": {
21-
"ciTargetName": "e2e-ci",
22-
"targetName": "e2e"
23-
}
24-
}
25-
],
17+
2618
"targetDefaults": {
19+
"lint": {
20+
"inputs": ["default", "{workspaceRoot}/.eslintrc.json"],
21+
"cache": true
22+
},
2723
"build-bin": {
2824
"cache": true
2925
},

package.json

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -49,19 +49,17 @@
4949
"@img/sharp-linux-x64": "^0.33.0",
5050
"@jscutlery/semver": "^4.2.0",
5151
"@k11r/nx-cloudflare-wrangler": "2.7.1",
52-
"@nx/cypress": "18.0.4",
53-
"@nx/devkit": "18.0.4",
54-
"@nx/eslint": "18.0.4",
55-
"@nx/eslint-plugin": "18.0.4",
56-
"@nx/jest": "18.0.4",
57-
"@nx/js": "18.0.4",
58-
"@nx/playwright": "18.0.4",
59-
"@nx/plugin": "18.0.4",
60-
"@nx/storybook": "18.0.4",
61-
"@nx/vite": "18.0.4",
62-
"@nx/workspace": "18.0.4",
52+
"@nx/cypress": "17.1.3",
53+
"@nx/devkit": "17.1.3",
54+
"@nx/eslint": "17.1.3",
55+
"@nx/eslint-plugin": "17.1.3",
56+
"@nx/jest": "17.1.3",
57+
"@nx/js": "17.1.3",
58+
"@nx/plugin": "17.2.3",
59+
"@nx/storybook": "17.1.3",
60+
"@nx/vite": "17.1.3",
61+
"@nx/workspace": "17.1.3",
6362
"@oddbird/popover-polyfill": "0.3.7",
64-
"@playwright/test": "^1.36.0",
6563
"@storybook/addon-a11y": "7.6.0",
6664
"@storybook/addon-coverage": "^0.0.9",
6765
"@storybook/addon-essentials": "7.6.0",
@@ -78,11 +76,11 @@
7876
"@types/eslint": "^8.44.2",
7977
"@types/estree-jsx": "^1.0.3",
8078
"@types/jest": "^29.4.0",
81-
"@types/node": "18.19.17",
82-
"@typescript-eslint/eslint-plugin": "6.21.0",
83-
"@typescript-eslint/parser": "6.21.0",
84-
"@vitest/coverage-v8": "0.34.6",
85-
"@vitest/ui": "0.34.7",
79+
"@types/node": "^20.5.7",
80+
"@typescript-eslint/eslint-plugin": "6.13.1",
81+
"@typescript-eslint/parser": "6.13.1",
82+
"@vitest/coverage-v8": "^0.34.3",
83+
"@vitest/ui": "^0.34.3",
8684
"all-contributors-cli": "^6.26.1",
8785
"autoprefixer": "^10.4.15",
8886
"axe-core": "^4.7.2",
@@ -101,10 +99,9 @@
10199
"cz-conventional-changelog": "^3.3.0",
102100
"danger": "^11.2.8",
103101
"dotenv": "16.3.1",
104-
"eslint": "8.48.0",
102+
"eslint": "^8.48.0",
105103
"eslint-config-prettier": "9.0.0",
106104
"eslint-plugin-cypress": "^2.14.0",
107-
"eslint-plugin-playwright": "^0.15.3",
108105
"eslint-plugin-qwik": "^1.4.0",
109106
"eslint-plugin-storybook": "^0.6.13",
110107
"focus-trap": "7.5.3",
@@ -117,7 +114,7 @@
117114
"ngx-deploy-npm": "^7.0.1",
118115
"node-fetch": "^3.3.2",
119116
"np": "^8.0.4",
120-
"nx": "18.0.4",
117+
"nx": "17.1.3",
121118
"postcss": "^8.4.29",
122119
"prettier": "^2.8.8",
123120
"prettier-plugin-tailwindcss": "0.4.1",
@@ -140,13 +137,13 @@
140137
"unified": "^11.0.4",
141138
"unist-util-visit": "^5.0.0",
142139
"verdaccio": "^5.0.4",
143-
"vite": "5.0.4",
140+
"vite": "^5.0.4",
144141
"vite-plugin-dts": "^3.5.3",
145142
"vite-plugin-eslint": "^1.8.1",
146143
"vite-plugin-inspect": "0.7.38",
147144
"vite-plugin-static-copy": "0.17.0",
148145
"vite-tsconfig-paths": "4.2.0",
149-
"vitest": "0.34.6",
146+
"vitest": "^0.34.3",
150147
"wrangler": "^3.11.0",
151148
"yargs": "17.7.2"
152149
},
@@ -162,6 +159,5 @@
162159
],
163160
"nx": {
164161
"includedScripts": []
165-
},
166-
"dependencies": {}
162+
}
167163
}

packages/cli-e2e/project.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
},
1616
"lint": {
1717
"executor": "@nx/eslint:lint",
18-
"outputs": ["{options.outputFile}"]
18+
"outputs": ["{options.outputFile}"],
19+
"options": { "lintFilePatterns": ["apps/website-e2e/**/*.{js,ts}"] }
1920
}
2021
},
2122
"implicitDependencies": ["cli"]

0 commit comments

Comments
 (0)