Skip to content

Commit 450e28b

Browse files
committed
chore(up 1.3.2): fix types
1 parent 5f46f05 commit 450e28b

File tree

8 files changed

+1587
-1558
lines changed

8 files changed

+1587
-1558
lines changed

apps/website/src/routes/docs/headless/combobox/examples/search-bar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export default component$(() => {
5050
<ComboboxInput
5151
onClick$={() => (isListboxOpenSig.value = !isListboxOpenSig.value)}
5252
class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm pl-6 pr-6"
53-
onKeyDown$={(e: any) => {
53+
onKeyDown$={(e: KeyboardEvent) => {
5454
if (e.key === 'Enter') {
5555
const inputElement = e.target as HTMLInputElement;
5656
window.location.href = `${docsPrefix}/${inputElement.value.toLowerCase()}`;

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
},
2929
"packageManager": "[email protected]",
3030
"devDependencies": {
31-
"@builder.io/qwik": "1.3.0",
32-
"@builder.io/qwik-city": "1.3.0",
31+
"@builder.io/qwik": "^1.3.2",
32+
"@builder.io/qwik-city": "^1.3.2",
3333
"@builder.io/vite-plugin-macro": "~0.0.7",
3434
"@commitlint/cli": "^17.7.1",
3535
"@commitlint/config-angular": "^17.7.0",
@@ -86,7 +86,7 @@
8686
"eslint": "^8.48.0",
8787
"eslint-config-prettier": "9.0.0",
8888
"eslint-plugin-cypress": "^2.14.0",
89-
"eslint-plugin-qwik": "1.3.0",
89+
"eslint-plugin-qwik": "^1.3.2",
9090
"eslint-plugin-storybook": "^0.6.13",
9191
"focus-trap": "7.5.3",
9292
"husky": "^8.0.3",

packages/kit-headless/src/components/combobox/combobox-popover.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export const ComboboxPopover = component$(
1010
(props: Partial<FloatingProps & PopoverImplProps>) => {
1111
const context = useContext(ComboboxContextId);
1212
const customPopoverId = useId();
13-
console.log('customPopoverId:', customPopoverId);
1413
const { showPopover, hidePopover } = usePopover(customPopoverId);
1514

1615
/* REMEMBER, whenever an option is selected or onMouseDown$ the listbox is closed, and the popover should sync to that */

packages/kit-headless/src/components/popover/floating.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@ import {
1818
autoPlacement as _autoPlacement,
1919
hide as _hide,
2020
} from '@floating-ui/dom';
21-
import { OmitSignalClass } from '@qwik-ui/utils';
2221

2322
declare global {
2423
interface Document {
2524
__NEEDS_POPOVER__?: true;
2625
}
2726
interface HTMLDivElement {
28-
popover?: 'manual' | 'auto' | true;
27+
popover?: 'manual' | 'auto';
2928
}
3029
}
3130

@@ -59,7 +58,7 @@ export type FloatingProps = {
5958
hide?: 'referenceHidden' | 'escaped';
6059
inline?: boolean;
6160
transform?: string;
62-
} & OmitSignalClass<QwikIntrinsicElements['div']>;
61+
} & QwikIntrinsicElements['div'];
6362

6463
export const FloatingPopover = component$(
6564
({

packages/kit-headless/src/components/popover/popover-impl.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { supportShowAnimation, supportClosingAnimation } from './utils';
1717

1818
export type PopoverImplProps = {
1919
id: string;
20-
popover?: string | null | undefined;
20+
popover?: 'manual' | 'auto';
2121
class?: ClassList;
2222
ref?: Signal<HTMLElement | undefined>;
2323
manual?: boolean;

packages/kit-headless/src/components/popover/popover-trigger.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ export const PopoverTrigger = component$<PopoverTriggerProps>(
111111
return (
112112
<button
113113
{...rest}
114-
// @ts-expect-error bad types
115114
popovertarget={popovertarget}
116115
onClick$={[
117116
rest.onClick$,

packages/kit-headless/src/components/tabs/tab.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import {
22
$,
33
QwikIntrinsicElements,
4-
Signal,
54
Slot,
65
component$,
76
useComputed$,
@@ -85,10 +84,7 @@ export const Tab = component$<TabProps>(({ selectedClassName, tabId, ...props })
8584
onMouseEnter$={[selectIfAutomatic$, props.onMouseEnter$]}
8685
aria-selected={isSelectedSig.value}
8786
tabIndex={isSelectedSig.value ? 0 : -1}
88-
class={[
89-
(props.class as Signal<string>)?.value ?? (props.class as string),
90-
classNamesSig.value,
91-
]}
87+
class={[props.class, classNamesSig.value]}
9288
onClick$={[$(() => contextService.selectTab$(tabId!)), props.onClick$]}
9389
>
9490
<Slot />

0 commit comments

Comments
 (0)