Skip to content

Commit 575db11

Browse files
authored
Merge pull request #641 from maiieul/to-shiki-forever
docs(shiki): use cloudflareAdapter SSG mode for every page
2 parents 0e61a4d + b3b4d84 commit 575db11

File tree

4 files changed

+94
-233
lines changed

4 files changed

+94
-233
lines changed

apps/website/adapters/cloudflare-pages/vite.config.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ export default extendConfig(baseConfig, () => {
1616
},
1717
plugins: [
1818
cloudflarePagesAdapter({
19-
// ssg: {
20-
// include: ['/*'],
21-
// }
19+
ssg: {
20+
include: ['/*'],
21+
},
2222
}),
2323
],
2424
};

apps/website/src/components/highlight/highlight.tsx

Lines changed: 21 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
1-
import {
2-
ClassList,
3-
PropsOf,
4-
component$,
5-
useSignal,
6-
useVisibleTask$,
7-
} from '@builder.io/qwik';
1+
import { ClassList, PropsOf, component$, useSignal, useTask$ } from '@builder.io/qwik';
82
import { CodeCopy } from '../code-copy/code-copy';
9-
import { codeToHtml } from 'shikiji';
3+
import { codeToHtml } from 'shiki';
104
import { cn } from '@qwik-ui/utils';
115

126
export type HighlightProps = PropsOf<'div'> & {
@@ -29,31 +23,28 @@ export const Highlight = component$(
2923
const codeSig = useSignal('');
3024

3125
// eslint-disable-next-line qwik/no-use-visible-task
32-
useVisibleTask$(
33-
async function createHighlightedCode() {
34-
let modifiedCode: string = code;
26+
useTask$(async function createHighlightedCode() {
27+
let modifiedCode: string = code;
3528

36-
let partsOfCode = modifiedCode.split(splitCommentStart);
37-
if (partsOfCode.length > 1) {
38-
modifiedCode = partsOfCode[1];
39-
}
29+
let partsOfCode = modifiedCode.split(splitCommentStart);
30+
if (partsOfCode.length > 1) {
31+
modifiedCode = partsOfCode[1];
32+
}
4033

41-
partsOfCode = modifiedCode.split(splitCommentEnd);
42-
if (partsOfCode.length > 1) {
43-
modifiedCode = partsOfCode[0];
44-
}
34+
partsOfCode = modifiedCode.split(splitCommentEnd);
35+
if (partsOfCode.length > 1) {
36+
modifiedCode = partsOfCode[0];
37+
}
4538

46-
const str = await codeToHtml(modifiedCode, {
47-
lang: language,
48-
themes: {
49-
light: 'poimandres',
50-
dark: 'poimandres',
51-
},
52-
});
53-
codeSig.value = str.toString();
54-
},
55-
{ strategy: 'document-idle' },
56-
);
39+
const str = await codeToHtml(modifiedCode, {
40+
lang: language,
41+
themes: {
42+
light: 'poimandres',
43+
dark: 'poimandres',
44+
},
45+
});
46+
codeSig.value = str.toString();
47+
});
5748

5849
return (
5950
<div class="code-example relative max-h-[31.25rem] rounded-b-sm">

package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@
176176
"qwik-themes": "^0.2.0",
177177
"react": "18.2.0",
178178
"react-dom": "18.2.0",
179-
"rehype-pretty-code": "^0.10.2",
179+
"rehype-pretty-code": "^0.13.0",
180180
"sass": "^1.66.1",
181-
"shikiji": "0.9.18",
181+
"shiki": "1.1.7",
182182
"specificity": "^1.0.0",
183183
"storybook": "^7.4.0",
184184
"storybook-framework-qwik": "^0.2.3",
@@ -215,6 +215,5 @@
215215
],
216216
"nx": {
217217
"includedScripts": []
218-
},
219-
"dependencies": {}
218+
}
220219
}

0 commit comments

Comments
 (0)