Skip to content

Commit 65a9dad

Browse files
authored
chore: update qwik deps to latest (#273)
1 parent 3ee249f commit 65a9dad

File tree

12 files changed

+48
-47
lines changed

12 files changed

+48
-47
lines changed

CODING_STANDARDS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export const Tooltip = component$(({ tip, position = 'top', type, ...props}: Too
8989
```
9090

9191
- Use class and not className when in the JSX and in the component props (if you expect to have a class props part if the component props).
92-
- Try to avoid using `useBrowserVisibleTask$` function. See [Qwik best practices](https://qwik.builder.io/docs/cheat/best-practices/) for the why.
92+
- Try to avoid using `useVisibleTask$` function. See [Qwik best practices](https://qwik.builder.io/docs/cheat/best-practices/) for the why.
9393
- Try to use the Slot element whenever the component can accept children
9494
- Use array spread on props to allow the component user to send props that override ours. For example:
9595

apps/website/src/components/header/header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default component$(() => {
4444
setThemeClass();
4545
});
4646

47-
const isDocsRoute = location.pathname.indexOf('/docs/') !== -1;
47+
const isDocsRoute = location.url.pathname.indexOf('/docs/') !== -1;
4848

4949
return (
5050
<header class="fixed w-full z-10 border-b border-slate-600">

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
"test:headless": "nx component-test headless --watch"
1515
},
1616
"devDependencies": {
17-
"@builder.io/qwik": "0.23.0",
18-
"@builder.io/qwik-city": "0.6.6",
17+
"@builder.io/qwik": "0.100.0",
18+
"@builder.io/qwik-city": "0.100.0",
1919
"@commitlint/cli": "^17.4.3",
2020
"@commitlint/config-angular": "^17.4.3",
2121
"@commitlint/config-conventional": "^17.4.3",

packages/headless/src/components/accordion/accordion.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
QRL,
88
Signal,
99
Slot,
10-
useBrowserVisibleTask$,
10+
useVisibleTask$,
1111
useContext,
1212
useContextProvider,
1313
useSignal,
@@ -48,7 +48,7 @@ export const Accordion = component$((props: AccordionProps) => {
4848

4949
useContextProvider(accordionContext, contextService);
5050

51-
useBrowserVisibleTask$(() => {
51+
useVisibleTask$(() => {
5252
contextService.setItemsBoxRef$(itemsBoxRef);
5353
const items = itemsBoxRef.value?.querySelectorAll<HTMLElement>('div.item');
5454
if (items?.length) {

packages/headless/src/components/menu/menu.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
QwikKeyboardEvent,
77
Signal,
88
Slot,
9-
useBrowserVisibleTask$,
9+
useVisibleTask$,
1010
useContext,
1111
useContextProvider,
1212
useId,
@@ -61,15 +61,15 @@ export const Menu = component$((props: MenuProps) => {
6161

6262
useContextProvider(quiMenuContext, menuContextService);
6363

64-
useBrowserVisibleTask$(({ track }) => {
64+
useVisibleTask$(({ track }) => {
6565
track(() => isExpanded.value);
6666
if (!isExpanded.value) {
6767
currentButtonInFocusIndex.value = -1;
6868
currentId.value = '';
6969
}
7070
});
7171

72-
useBrowserVisibleTask$(() => {
72+
useVisibleTask$(() => {
7373
const options = container.value?.querySelectorAll<HTMLElement>('button');
7474
if (options?.length) {
7575
options.forEach((option) => children.push(option));

packages/headless/src/components/popover/popover-content.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {
22
component$,
33
Slot,
4-
useBrowserVisibleTask$,
4+
useVisibleTask$,
55
useContext,
66
useSignal,
77
useStylesScoped$,
@@ -14,7 +14,7 @@ export const PopoverContent = component$(() => {
1414
const contextService = useContext(PopoverContext);
1515
useStylesScoped$(styles);
1616

17-
useBrowserVisibleTask$(() => {
17+
useVisibleTask$(() => {
1818
contextService.setOverlayRef$(ref);
1919
});
2020

packages/headless/src/components/popover/popover-trigger.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {
22
$,
33
component$,
44
Slot,
5-
useBrowserVisibleTask$,
5+
useVisibleTask$,
66
useContext,
77
useSignal,
88
useStylesScoped$,
@@ -15,7 +15,7 @@ export const PopoverTrigger = component$(() => {
1515
const contextService = useContext(PopoverContext);
1616
useStylesScoped$(styles);
1717

18-
useBrowserVisibleTask$(() => {
18+
useVisibleTask$(() => {
1919
contextService.setTriggerRef$(ref);
2020
});
2121

packages/headless/src/components/popover/popover.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
QwikMouseEvent,
66
Signal,
77
Slot,
8-
useBrowserVisibleTask$,
8+
useVisibleTask$,
99
useContextProvider,
1010
useSignal,
1111
useStore,
@@ -154,7 +154,7 @@ export const Popover = component$((props: PopoverProps) => {
154154
* Sync isOpen external property with internal context
155155
* NOTE: useful when the popover status is controlled from the outside
156156
*/
157-
useBrowserVisibleTask$(({ track }) => {
157+
useVisibleTask$(({ track }) => {
158158
track(() => props.isOpen);
159159
contextService.isOpen = !!props.isOpen;
160160
});
@@ -163,7 +163,7 @@ export const Popover = component$((props: PopoverProps) => {
163163
* Watch isOpen context property
164164
* and apply CSS classes to show and hide the Popover Content
165165
*/
166-
useBrowserVisibleTask$(({ track }) => {
166+
useVisibleTask$(({ track }) => {
167167
track(() => contextService.isOpen);
168168
if (!triggerRef.value || !contentRef.value) return;
169169

packages/headless/src/components/slider/slider.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
PropFunction,
55
Signal,
66
Slot,
7-
useBrowserVisibleTask$,
7+
useVisibleTask$,
88
useContextProvider,
99
useSignal,
1010
} from '@builder.io/qwik';
@@ -56,13 +56,13 @@ export const Slider = component$(
5656
percentage: percentageSignal,
5757
};
5858

59-
useBrowserVisibleTask$(async ({ track }) => {
59+
useVisibleTask$(async ({ track }) => {
6060
track(() => rootPositionRef);
6161
contextService.positionX.value =
6262
rootPositionRef.value?.getBoundingClientRect().x;
6363
});
6464

65-
useBrowserVisibleTask$(async ({ track }) => {
65+
useVisibleTask$(async ({ track }) => {
6666
const newValue = track(() => sliderValue.value);
6767
if (onChange$) {
6868
onChange$(newValue);

packages/headless/src/components/tabs/tabs.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ import {
88
Slot,
99
useContext,
1010
useContextProvider,
11-
useMount$,
11+
useTask$,
1212
useSignal,
13+
useVisibleTask$,
1314
} from '@builder.io/qwik';
1415

1516
export type Behavior = 'automatic' | 'manual';
@@ -90,7 +91,7 @@ export const Tab = component$(
9091
const contextService = useContext(tabsContext);
9192
const thisTabIndex = useSignal(0);
9293

93-
useMount$(async () => {
94+
useTask$(async () => {
9495
thisTabIndex.value = await contextService.getNextTabIndex();
9596
});
9697
const isSelected = () =>
@@ -138,7 +139,7 @@ export const TabPanel = component$(({ ...props }: TabPanelProps) => {
138139
const thisPanelIndex = useSignal(0);
139140
const isSelected = () =>
140141
thisPanelIndex.value === contextService.selectedIndex.value;
141-
useMount$(async () => {
142+
useVisibleTask$(async () => {
142143
thisPanelIndex.value = await contextService.getNextPanelIndex();
143144
});
144145
return (

0 commit comments

Comments
 (0)