You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
refactor(package.json): refactor scripts for convenience pnpm workflow (#501)
* refactor(package.json): add scripts for convenience pnpm workflow
Tried to mimic Qwik package convention with the "." notation
* fix(pnpm link.dist): fix cd
* chore(package.json): remove not yet used dependencies
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+47-74Lines changed: 47 additions & 74 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,42 +1,33 @@
1
1
# Contribution Guidelines
2
2
3
3
We would love for you to contribute to this project.
4
-
As a contributor, here are the guidelines we would like you to follow:
4
+
As a contributor, here are the guidelines we would like you to follow 👇
5
5
6
-
## Be Kind - Code of Conduct
6
+
###Be Kind - Code of Conduct
7
7
8
-
Please read and follow our [Code of Conduct](CODE_OF_CONDUCT.md) to help us keep this project open and inclusive.
8
+
Please, read and follow our [Code of Conduct](CODE_OF_CONDUCT.md) to help us keep this project open and inclusive.
9
9
10
-
<br/>
11
-
12
-
## Found a bug? Want a feature? - Submit an Issue
10
+
### Found a bug? Want a feature? - Submit an Issue
13
11
14
12
[Choose an issue template](https://github.com/qwikifiers/qwik-ui/issues/new/choose) to file a bug report / feature request.
15
13
16
-
<br/>
17
-
18
14
## Ready to contribute a Pull Request (PR)?
19
15
20
-
<br/>
16
+
### 1. Make sure you aren't duplicating someone else's efforts.
21
17
22
-
### ▶ 1. First - [Search this repo for existing PRs](https://github.com/qwikifiers/qwik-ui/pulls) !
18
+
-[Look out for existing PRs](https://github.com/qwikifiers/qwik-ui/pulls)
23
19
24
-
Try to find an open or closed PR that relates to the change you want to introduce.
20
+
### 2. Make sure your idea is the right way to solve the issue.
25
21
26
-
<br/>
22
+
[Look out for existing issues](https://github.com/qwikifiers/qwik-ui/issues) that may describe the problem you're fixing, or document the design for the feature you'd like to add.
27
23
28
-
### ▶ 2. **Before you start coding - [find](https://github.com/qwikifiers/qwik-ui/issues) / [create an issue](https://github.com/qwikifiers/qwik-ui/issues/new/choose)**
24
+
Please, consider [creating an issue](https://github.com/qwikifiers/qwik-ui/issues/new) if you can't find anything.
29
25
30
-
**Make sure there's an issue** describing the problem you're fixing, or documents the design for the feature you'd like to add.
31
26
Discussing the design up front helps to ensure that we're ready to accept your work.
32
27
33
-
**Don't waste your time working on code before you got a 👍 in an issue comment.**
34
-
35
-
<br/>
28
+
### 3. Fork this repo and create a branch.
36
29
37
-
### ▶ 3. Fork this repo and create a branch.
38
-
39
-
- Hit that "Fork" button above (in this repo's GitHub page).
30
+
- Hit the "Fork" button (top-right of the github repository).
- From the root of the project run the following command:
52
+
- From the root of the project run the install script:
64
53
65
54
```shell
66
55
pnpm install
67
56
```
68
57
69
-
- Download [Nx](https://nx.dev/):
70
-
71
-
```shell
72
-
pnpm install --global nx@latest
73
-
```
74
-
75
-
- Then run this command to get the qwik-ui documentation site in dev mode:
58
+
- Then run the dev script to get the qwik-ui documentation site in dev mode:
76
59
77
60
```shell
78
-
pnpm website
61
+
pnpm dev
79
62
```
80
63
81
64
- Visit the URL printed in the console and you'll have a page opened with the suite of widgets.
82
65
83
-
- Once you made some changes in either package (`headless`, `tailwind` or `material`), you will see them immediately reflected on the page.
66
+
- Once you made some changes in either package (`headless` or `fluffy`) or the documentation website (`apps/website`), you will see them immediately reflected on the page.
84
67
85
68
Below is a list of other commands that you might find useful:
86
69
87
70
- Build the qwik-ui documentation:
88
71
89
72
```shell
90
-
nx build website
73
+
pnpm build
91
74
```
92
75
93
76
- Preview of the qwik-ui documentation (no HMR):
94
77
95
78
```shell
96
-
nx preview website
79
+
pnpm preview
97
80
```
98
81
99
82
- Build the Cloudfare version of the qwik-ui documentation
100
83
101
84
```shell
102
-
nx build-cloudfare website
85
+
pnpm build.clouflare
103
86
```
104
87
105
88
- Preview the Cloudfare build of the qwik-ui documentation (no HMR)
106
89
107
90
```shell
108
-
nx preview-cloudflare website
91
+
pnpm preview.clouflare
109
92
```
110
93
111
-
### ▶ 5. Make sure you add / modify tests
94
+
### 5. Make sure you add / modify tests
112
95
113
96
Run either command to make sure there aren't any errors.
114
97
115
98
```shell
116
-
nx component-testheadless --skip-nx-cache
99
+
pnpm test.headless --skip-nx-cache
117
100
```
118
101
119
-
Or
102
+
This will set up the Cypress component testing GUI. Please refer to official Cypress [documentation](https://docs.cypress.io/guides/overview/why-cypress) for further assistance.
103
+
104
+
### 6. Commit your changes using commitizen:
105
+
106
+
Instead of `git commit` use the following command:
120
107
121
108
```shell
122
-
pnpm run test:headless --skip-nx-cache
109
+
pnpm commit
123
110
```
124
111
125
-
Both commands will set up the Cypress component testing GUI, so you are free to chose which syntax you prefer. Please refer to official Cypress [documentation](https://docs.cypress.io/guides/overview/why-cypress) for further assistance.
126
-
<br/>
112
+
Or if you prefer to keep your git workflow, you can install commitizen globally:
127
113
128
-
### ▶ 6. Commit your changes using commitizen:
114
+
```shell
115
+
pnpm install -g commitizen
116
+
```
129
117
130
-
Instead of `git commit` use the following command:
118
+
And run it with:
131
119
132
120
```shell
133
-
pnpm run commit
121
+
git cz
134
122
```
135
123
136
124
It will then ask you a bunch of questions.
137
125
138
126
This will create a descriptive commit message that follows the
0 commit comments