Skip to content

Commit 82fbb1a

Browse files
Merge pull request #672 from thejackshelton/shiki-utf8
fix: docs examples
2 parents 72e69ea + d199f56 commit 82fbb1a

File tree

15 files changed

+135
-19
lines changed

15 files changed

+135
-19
lines changed

apps/website/src/components/highlight/highlight.tsx

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
1-
import { ClassList, PropsOf, component$, useSignal, useTask$ } from '@builder.io/qwik';
1+
import {
2+
ClassList,
3+
PropsOf,
4+
component$,
5+
useSignal,
6+
useTask$,
7+
useVisibleTask$,
8+
$,
9+
} from '@builder.io/qwik';
210
import { CodeCopy } from '../code-copy/code-copy';
311
import { getHighlighterCore } from 'shiki';
412
import { cn } from '@qwik-ui/utils';
13+
import { isDev } from '@builder.io/qwik/build';
514

615
export type HighlightProps = PropsOf<'div'> & {
716
code: string;
@@ -22,8 +31,7 @@ export const Highlight = component$(
2231
}: HighlightProps) => {
2332
const codeSig = useSignal('');
2433

25-
// eslint-disable-next-line qwik/no-use-visible-task
26-
useTask$(async function createHighlightedCode() {
34+
const addShiki$ = $(async () => {
2735
let modifiedCode: string = code;
2836

2937
let partsOfCode = modifiedCode.split(splitCommentStart);
@@ -59,6 +67,22 @@ export const Highlight = component$(
5967
codeSig.value = str.toString();
6068
});
6169

70+
useTask$(async function createHighlightedCode() {
71+
if (!isDev) {
72+
await addShiki$();
73+
}
74+
});
75+
76+
// eslint-disable-next-line qwik/no-use-visible-task
77+
useVisibleTask$(
78+
async () => {
79+
if (isDev) {
80+
await addShiki$();
81+
}
82+
},
83+
{ strategy: 'document-ready' },
84+
);
85+
6286
return (
6387
<div class="code-example relative max-h-[31.25rem]">
6488
<CodeCopy

apps/website/src/routes/docs/headless/accordion/examples/custom-heading.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default component$(() => {
1111
return (
1212
<>
1313
<div class="flex w-full justify-center">
14-
<AccordionRoot>
14+
<AccordionRoot class="w-full">
1515
<AccordionItem class="border-b">
1616
<AccordionHeader as="h4">
1717
<AccordionTrigger class="group flex w-full items-center justify-between rounded-t-sm py-4 text-left hover:underline">

apps/website/src/routes/docs/headless/accordion/examples/default-value.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default component$(() => {
1111
return (
1212
<>
1313
<div class="flex w-full justify-center">
14-
<AccordionRoot>
14+
<AccordionRoot class="w-full">
1515
<AccordionItem class="border-b">
1616
<AccordionHeader as="h3">
1717
<AccordionTrigger class="group flex w-full items-center justify-between rounded-t-sm py-4 text-left hover:underline">

apps/website/src/routes/docs/headless/accordion/examples/disabled.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default component$(() => {
1212
return (
1313
<>
1414
<div class="flex w-full justify-center">
15-
<AccordionRoot>
15+
<AccordionRoot class="w-full">
1616
<AccordionItem class="border-b">
1717
<AccordionHeader as="h3">
1818
<AccordionTrigger class="group flex w-full items-center justify-between rounded-t-sm py-4 text-left hover:underline">

apps/website/src/routes/docs/headless/accordion/examples/dynamic.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export default component$(({ itemsLength = 3 }: DynamicAccordionProps) => {
5353
</label>
5454
</div>
5555

56-
<AccordionRoot>
56+
<AccordionRoot class="w-full">
5757
{itemStore.map(({ label, id }, index) => {
5858
return (
5959
<AccordionItem id={`${id}`} key={id} class="border-b">

apps/website/src/routes/docs/headless/accordion/examples/focused-index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export default component$(() => {
1414
<>
1515
<div class="flex w-full flex-col items-center gap-4">
1616
<AccordionRoot
17+
class="w-full"
1718
onFocusIndexChange$={(index: number) => {
1819
focusedIndexSig.value = index;
1920
}}

apps/website/src/routes/docs/headless/accordion/examples/hero.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default component$(() => {
1212
return (
1313
<>
1414
<div class="flex w-full justify-center">
15-
<AccordionRoot animated enhance={true}>
15+
<AccordionRoot class="w-full" animated enhance={true}>
1616
<AccordionItem class="border-b">
1717
<AccordionHeader as="h3">
1818
<AccordionTrigger class="group flex w-full items-center justify-between rounded-t-sm py-4 text-left hover:underline">

apps/website/src/routes/docs/headless/accordion/examples/multi.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default component$(() => {
1212
return (
1313
<>
1414
<div class="flex w-full justify-center">
15-
<AccordionRoot collapsible animated behavior="multi">
15+
<AccordionRoot class="w-full" collapsible animated behavior="multi">
1616
<AccordionItem class="border-b">
1717
<AccordionHeader as="h3">
1818
<AccordionTrigger class="group flex w-full items-center justify-between rounded-t-sm py-4 text-left hover:underline">

apps/website/src/routes/docs/headless/accordion/examples/non-collapsible.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default component$(() => {
1313
return (
1414
<>
1515
<div class="flex w-full justify-center">
16-
<AccordionRoot animated collapsible={false}>
16+
<AccordionRoot class="w-full" animated collapsible={false}>
1717
<AccordionItem class="border-b">
1818
<AccordionHeader as="h3">
1919
<AccordionTrigger class="group flex w-full items-center justify-between rounded-t-sm py-4 text-left hover:underline">

apps/website/src/routes/docs/headless/accordion/examples/selected-index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export default component$(() => {
1414
<>
1515
<div class="flex w-full flex-col items-center gap-4">
1616
<AccordionRoot
17+
class="w-full"
1718
onSelectedIndexChange$={(index: number) => {
1819
selectedIndexSig.value = index;
1920
}}

0 commit comments

Comments
 (0)