Skip to content

Commit 8e7c1a9

Browse files
Merge pull request #782 from thejackshelton/accordion-boundary
fix: remove context exports and refactor context file: collapsible
2 parents 8ea6960 + ca19862 commit 8e7c1a9

File tree

6 files changed

+19
-10
lines changed

6 files changed

+19
-10
lines changed

packages/kit-headless/src/components/collapsible/collapsible-content.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
useTask$,
88
PropsOf,
99
} from '@builder.io/qwik';
10-
import { collapsibleContextId } from './collapsible-context-id';
10+
import { collapsibleContextId } from './collapsible-context';
1111

1212
export type CollapsibleContentProps = PropsOf<'div'>;
1313

packages/kit-headless/src/components/collapsible/collapsible-context-id.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { createContextId } from '@builder.io/qwik';
2+
3+
export const collapsibleContextId = createContextId<CollapsibleContext>('Collapsible');
4+
5+
import { type QRL, type Signal } from '@builder.io/qwik';
6+
7+
export interface CollapsibleContext {
8+
itemId: string;
9+
isOpenSig: Signal<boolean>;
10+
triggerRef: Signal<HTMLButtonElement | undefined>;
11+
contentRef: Signal<HTMLElement | undefined>;
12+
contentHeightSig: Signal<number | null>;
13+
getContentDimensions$: QRL<() => void>;
14+
disabled: boolean | undefined;
15+
collapsible?: boolean;
16+
}

packages/kit-headless/src/components/collapsible/collapsible-trigger.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { $, PropsOf, Slot, component$, useContext, useOnWindow } from '@builder.io/qwik';
2-
import { collapsibleContextId } from './collapsible-context-id';
2+
import { collapsibleContextId } from './collapsible-context';
33

44
export const HCollapsibleTrigger = component$<PropsOf<'button'>>(
55
({ onClick$, ...props }) => {

packages/kit-headless/src/components/collapsible/collapsible.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ import {
1111
useTask$,
1212
} from '@builder.io/qwik';
1313

14-
import { collapsibleContextId } from './collapsible-context-id';
15-
import { type CollapsibleContext } from './collapsible-context.type';
14+
import { type CollapsibleContext, collapsibleContextId } from './collapsible-context';
1615
import { isBrowser } from '@builder.io/qwik/build';
1716
import { useCollapsible } from './use-collapsible';
1817

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
export { HCollapsible as Root } from './collapsible';
22
export { HCollapsibleContent as Content } from './collapsible-content';
33
export { HCollapsibleTrigger as Trigger } from './collapsible-trigger';
4-
export * from './collapsible-context.type';
5-
export * from './collapsible-context-id';

0 commit comments

Comments
 (0)