Merge pull request #747 from thejackshelton/update-nx

feat: upgrade to nx 19

Author: thejackshelton

.github/workflows/test.yml

@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        node_version: [18, 20, 21, 22]
+        node_version: [18, 20, 22]
 
     steps:
       - name: Cancel Previous Runs

apps/website/src/routes/docs/headless/select/examples/validation.tsx

@@ -1,21 +1,16 @@
 import { component$, useStyles$, $ } from '@builder.io/qwik';
 import { LuCheck } from '@qwikest/icons/lucide';
 import { Select } from '@qwik-ui/headless';
-import { useForm, required, InitialValues } from '@modular-forms/qwik';
-import { routeLoader$ } from '@builder.io/qwik-city';
+import { useForm, required } from '@modular-forms/qwik';
 
 type Users = {
   firstName: string;
 };
 
-export const useSelectFormLoader = routeLoader$<InitialValues<Users>>(() => ({
-  firstName: '',
-}));
-
 export default component$(() => {
   const users = ['Tim', 'Ryan', 'Jim', 'Jessie', 'Abby'];
   const [, { Form, Field }] = useForm<Users>({
-    loader: useSelectFormLoader(),
+    loader: { value: { firstName: '' } },
   });
 
   useStyles$(styles);

apps/website/src/routes/docs/headless/select/index.mdx

@@ -4,8 +4,6 @@ title: Qwik UI | Select
 
 import { FeatureList } from '~/components/feature-list/feature-list';
 import { statusByComponent } from '~/_state/component-statuses';
-import { useSelectFormLoader } from './examples/validation.tsx';
-export { useSelectFormLoader } from './examples/validation.tsx';
 
 <StatusBanner status={statusByComponent.headless.Select} />
 

migrations.json

@@ -1,22 +1,5 @@
 {
   "migrations": [
-    {
-      "cli": "nx",
-      "version": "17.3.0-beta.6",
-      "description": "Updates the nx wrapper.",
-      "implementation": "./src/migrations/update-17-3-0/update-nxw",
-      "package": "nx",
-      "name": "17.3.0-update-nx-wrapper"
-    },
-    {
-      "cli": "nx",
-      "version": "18.0.0-beta.2",
-      "description": "Updates nx.json to disabled adding plugins when generating projects in an existing Nx workspace",
-      "implementation": "./src/migrations/update-18-0-0/disable-crystal-for-existing-workspaces",
-      "x-repair-skip": true,
-      "package": "nx",
-      "name": "18.0.0-disable-adding-plugins-for-existing-workspaces"
-    },
     {
       "version": "18.1.0-beta.3",
       "description": "Moves affected.defaultBase to defaultBase in `nx.json`",
@@ -26,33 +9,11 @@
     },
     {
       "cli": "nx",
-      "version": "17.2.6-beta.1",
-      "description": "Rename workspace rules from @nx/workspace/name to @nx/workspace-name",
-      "implementation": "./src/migrations/update-17-2-6-rename-workspace-rules/rename-workspace-rules",
-      "package": "@nx/eslint-plugin",
-      "name": "update-17-2-6-rename-workspace-rules"
-    },
-    {
-      "version": "17.2.0-beta.10",
-      "description": "Update vite config.",
-      "implementation": "./src/migrations/update-17-2-0/update-vite-config",
-      "package": "@nx/vite",
-      "name": "update-vite-config"
-    },
-    {
-      "version": "17.3.0-beta.0",
-      "description": "Move the vitest coverage thresholds in their own object if exists and add reporters.",
-      "implementation": "./src/migrations/update-17-3-0/vitest-coverage-and-reporters",
-      "package": "@nx/vite",
-      "name": "vitest-coverage-and-reporters"
-    },
-    {
-      "cli": "nx",
-      "version": "17.3.1-beta.0",
-      "description": "Add project property to playwright config",
-      "implementation": "./src/migrations/update-17-3-1/add-project-to-config",
-      "package": "@nx/playwright",
-      "name": "17-3-1-add-project-to-config"
+      "version": "18.1.0-beta.3",
+      "description": "Update to Cypress ^13.6.6 if the workspace is using Cypress v13 to ensure workspaces don't use v13.6.5 which has an issue when verifying Cypress.",
+      "implementation": "./src/migrations/update-18-1-0/update-cypress-version-13-6-6",
+      "package": "@nx/cypress",
+      "name": "update-cypress-version-13-6-6"
     },
     {
       "cli": "nx",
@@ -61,28 +22,6 @@
       "implementation": "./src/migrations/update-18-1-0/remove-baseUrl-from-project-json",
       "package": "@nx/playwright",
       "name": "18-1-0-remove-baseUrl-from-project-json"
-    },
-    {
-      "cli": "nx",
-      "version": "18.1.0-beta.3",
-      "description": "Update to Cypress ^13.6.6 if the workspace is using Cypress v13 to ensure workspaces don't use v13.6.5 which has an issue when verifying Cypress.",
-      "implementation": "./src/migrations/update-18-1-0/update-cypress-version-13-6-6",
-      "package": "@nx/cypress",
-      "name": "update-cypress-version-13-6-6"
-    },
-    {
-      "version": "17.2.0-beta.0",
-      "description": "Simplify eslintFilePatterns",
-      "implementation": "./src/migrations/update-17-2-0/simplify-eslint-patterns",
-      "package": "@nx/eslint",
-      "name": "simplify-eslint-patterns"
-    },
-    {
-      "version": "17.2.9",
-      "description": "Move executor options to target defaults",
-      "implementation": "./src/migrations/update-17-2-9/move-options-to-target-defaults",
-      "package": "@nx/eslint",
-      "name": "move-options-to-target-defaults"
     }
   ]
 }

nx.json

@@ -1,8 +1,5 @@
 {
   "$schema": "./node_modules/nx/schemas/nx-schema.json",
-  "affected": {
-    "defaultBase": "main"
-  },
   "workspaceLayout": {
     "appsDir": "apps",
     "libsDir": "packages"
@@ -56,5 +53,7 @@
       "!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
       "!{projectRoot}/tsconfig.spec.json"
     ]
-  }
+  },
+  "nxCloudAccessToken": "MzViMzc1MGQtMDQyNi00N2E3LTliMmYtYWI4ZGIxYWJjYzE3fHJlYWQtd3JpdGU=",
+  "defaultBase": "main"
 }

package.json

@@ -59,17 +59,17 @@
     "@img/sharp-linux-x64": "^0.33.0",
     "@jscutlery/semver": "^4.2.0",
     "@k11r/nx-cloudflare-wrangler": "3.0.0-feat-sst-upgrade.1",
-    "@nx/cypress": "18.0.0",
-    "@nx/devkit": "18.0.0",
-    "@nx/eslint": "18.0.0",
-    "@nx/eslint-plugin": "18.0.0",
-    "@nx/jest": "18.0.0",
-    "@nx/js": "18.0.0",
-    "@nx/playwright": "18.0.0",
-    "@nx/plugin": "18.0.0",
-    "@nx/storybook": "18.0.0",
-    "@nx/vite": "18.0.0",
-    "@nx/workspace": "18.0.0",
+    "@nx/cypress": "19.0.4",
+    "@nx/devkit": "19.0.4",
+    "@nx/eslint": "19.0.4",
+    "@nx/eslint-plugin": "19.0.4",
+    "@nx/jest": "19.0.4",
+    "@nx/js": "19.0.4",
+    "@nx/playwright": "19.0.4",
+    "@nx/plugin": "19.0.4",
+    "@nx/storybook": "19.0.4",
+    "@nx/vite": "19.0.4",
+    "@nx/workspace": "19.0.4",
     "@oddbird/popover-polyfill": "0.4.3",
     "@playwright/test": "^1.41.2",
     "@qwikest/icons": "0.0.13",
@@ -99,8 +99,8 @@
     "@types/react-dom": "18.0.11",
     "@typescript-eslint/eslint-plugin": "7.9.0",
     "@typescript-eslint/parser": "7.9.0",
-    "@vitest/coverage-v8": "0.34.6",
-    "@vitest/ui": "0.34.7",
+    "@vitest/coverage-v8": "1.6.0",
+    "@vitest/ui": "1.6.0",
     "all-contributors-cli": "^6.26.1",
     "ansis": "2.3.0",
     "autoprefixer": "^10.4.15",
@@ -113,7 +113,7 @@
     "clsx": "^2.0.0",
     "commitizen": "^4.3.0",
     "commitlint": "^17.7.1",
-    "cypress": "^13.0.0",
+    "cypress": "^13.6.6",
     "cypress-axe": "1.4.0",
     "cypress-ct-qwik": "0.3.0",
     "cypress-real-events": "1.10.3",
@@ -137,7 +137,7 @@
     "ngx-deploy-npm": "^7.0.1",
     "node-fetch": "^3.3.2",
     "np": "^8.0.4",
-    "nx": "18.0.0",
+    "nx": "19.0.4",
     "postcss": "^8.4.29",
     "prettier": "^3.2.5",
     "prettier-plugin-tailwindcss": "^0.4.1",
@@ -170,7 +170,7 @@
     "vite-plugin-inspect": "0.7.38",
     "vite-plugin-static-copy": "0.17.0",
     "vite-tsconfig-paths": "4.2.0",
-    "vitest": "0.34.6",
+    "vitest": "1.6.0",
     "wrangler": "^3.57.0",
     "yargs": "17.7.2"
   },