refactor(modal): destrucure ...props first on <dialog>

GregOnNet · GregOnNet · commit cabdea4e1e19 · 2023-10-25T11:50:25.000+02:00
diff --git a/packages/kit-headless/src/components/modal/modal.tsx b/packages/kit-headless/src/components/modal/modal.tsx
@@ -86,8 +86,8 @@ export const Modal = component$((props: ModalProps) => {
 
   return (
     <dialog
-      role={props.alert === true ? 'alertdialog' : 'dialog'}
       {...props}
+      role={props.alert === true ? 'alertdialog' : 'dialog'}
       ref={modalRefSig}
       onClick$={(event) => closeOnBackdropClick$(event)}
     >

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,8 @@ export const Modal = component$((props: ModalProps) => {`
`86`	`86`
`87`	`87`	`return (`
`88`	`88`	`<dialog`
`89`		`- role={props.alert === true ? 'alertdialog' : 'dialog'}`
`90`	`89`	`{...props}`
	`90`	`+ role={props.alert === true ? 'alertdialog' : 'dialog'}`
`91`	`91`	`ref={modalRefSig}`
`92`	`92`	`onClick$={(event) => closeOnBackdropClick$(event)}`
`93`	`93`	`>`