Skip to content

Commit e62895b

Browse files
Merge pull request #566 from thejackshelton/popover-improvements
docs(improves code mdx and combobox examples)
2 parents 9d0a909 + a10cbf1 commit e62895b

File tree

25 files changed

+48
-46
lines changed

25 files changed

+48
-46
lines changed

apps/website/src/components/mdx-components/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,10 @@ export const components: Record<string, any> = {
146146
>(({ __rawString__, ...props }) => {
147147
return (
148148
<div
149+
{...props}
149150
class={[
150151
twMerge(
151-
'code-example relative -mx-6 max-h-[31.25rem] rounded-xl bg-slate-900 lg:-mx-8',
152+
'code-example relative -mx-6 mb-6 max-h-[31.25rem] rounded-xl bg-slate-900 lg:-mx-8',
152153
(props.class as Signal<string>)?.value ?? (props.class as string),
153154
),
154155
]}
@@ -158,7 +159,6 @@ export const components: Record<string, any> = {
158159
code={__rawString__}
159160
/>
160161
<div
161-
{...props}
162162
style={''} // required to override shiki's
163163
class="tab-size max-h-[31.25rem] max-w-full overflow-auto rounded-xl border bg-gradient-to-b from-slate-900 to-slate-800 p-6 text-sm"
164164
>
@@ -171,7 +171,7 @@ export const components: Record<string, any> = {
171171
}),
172172
code: component$<QwikIntrinsicElements['code']>(() => {
173173
return (
174-
<code>
174+
<code class="whitespace-pre-wrap">
175175
<Slot />
176176
</code>
177177
);

apps/website/src/routes/docs/headless/combobox/examples/custom-filter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export default component$(() => {
4242
>
4343
<ComboboxLabel class=" font-semibold">Countries 🚩</ComboboxLabel>
4444
<ComboboxControl class="relative flex items-center rounded-sm border">
45-
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6" />
45+
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6" />
4646
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
4747
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />
4848
</ComboboxTrigger>

apps/website/src/routes/docs/headless/combobox/examples/custom-keys.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export default component$(() => {
5353
>
5454
<ComboboxLabel class=" font-semibold">Pokemon 🦏</ComboboxLabel>
5555
<ComboboxControl class="relative flex items-center rounded-sm border">
56-
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6" />
56+
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6" />
5757
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
5858
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />
5959
</ComboboxTrigger>

apps/website/src/routes/docs/headless/combobox/examples/default-label.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default component$(() => {
2020
<Combobox class="w-fit" defaultLabel={names[2]} options={names}>
2121
<ComboboxLabel>Default Label</ComboboxLabel>
2222
<ComboboxControl class="relative rounded-sm border">
23-
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6" />
23+
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6" />
2424
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
2525
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />
2626
</ComboboxTrigger>

apps/website/src/routes/docs/headless/combobox/examples/disable-blur.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default component$(() => {
3939
<ComboboxControl class="relative flex items-center rounded-sm border">
4040
<ComboboxInput
4141
disableOnBlur={true}
42-
class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6"
42+
class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6"
4343
/>
4444
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
4545
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />

apps/website/src/routes/docs/headless/combobox/examples/disabled.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default component$(() => {
3535
<Combobox class="w-fit" options={disabledExample} optionDisabledKey="myDisabledKey">
3636
<ComboboxLabel class=" font-semibold">Disabled ⛔</ComboboxLabel>
3737
<ComboboxControl class="relative flex items-center rounded-sm border">
38-
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6" />
38+
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6" />
3939
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
4040
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />
4141
</ComboboxTrigger>

apps/website/src/routes/docs/headless/combobox/examples/hero.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default component$(() => {
4646
<ComboboxControl class="relative flex items-center rounded-sm border">
4747
<ComboboxInput
4848
placeholder="Jim"
49-
class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6"
49+
class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6"
5050
/>
5151
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
5252
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />

apps/website/src/routes/docs/headless/combobox/examples/hide.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export default component$(() => {
4343
}
4444
>
4545
<ComboboxControl class="relative flex items-center rounded-sm border">
46-
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6" />
46+
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6" />
4747
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
4848
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />
4949
</ComboboxTrigger>

apps/website/src/routes/docs/headless/combobox/examples/highlighted-index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export default component$(() => {
3131
bind:highlightedIndexSig={highlightedIndexSig}
3232
>
3333
<ComboboxControl class="relative flex items-center rounded-sm border">
34-
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-fit px-2 pr-6" />
34+
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-fit rounded-sm px-2 pr-6" />
3535
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
3636
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />
3737
</ComboboxTrigger>

apps/website/src/routes/docs/headless/combobox/examples/object.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default component$(() => {
3030
<Combobox class="w-fit" options={objectExample}>
3131
<ComboboxLabel class=" font-semibold">Jedi ⚔️</ComboboxLabel>
3232
<ComboboxControl class="relative flex items-center rounded-sm border">
33-
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 px-2 pr-6" />
33+
<ComboboxInput class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm px-2 pr-6" />
3434
<ComboboxTrigger class="group absolute right-0 h-6 w-6">
3535
<ComboboxIcon class="stroke-foreground transition-transform duration-[450ms] group-aria-expanded:-rotate-180" />
3636
</ComboboxTrigger>

0 commit comments

Comments
 (0)