Skip to content

Commit e6543b0

Browse files
committed
Fix progress tests.
1 parent 439511f commit e6543b0

File tree

2 files changed

+32
-6
lines changed

2 files changed

+32
-6
lines changed

apps/component-tests/src/components/showcase-test/showcase-test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const ShowcaseTest = component$(() => {
2222

2323
return (
2424
<>
25-
<section class="flex flex-col items-center">
25+
<section class="flex w-full flex-col items-center">
2626
{MetaGlobComponentSig.value && <MetaGlobComponentSig.value />}
2727
</section>
2828
</>

packages/kit-headless/src/components/progress/progress.test.ts

Lines changed: 31 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,27 +10,53 @@ async function setup(page: Page, exampleName: string) {
1010
return { driver, getRoot, getProgressState, getProgressValue, getProgressIndicator };
1111
}
1212

13-
test.describe('Progress Bar usaged', () => {
14-
test(`should have root and indicator`, async ({ page }) => {
13+
test.describe('Critical functionality', () => {
14+
test(`GIVEN a progress
15+
WHEN the progress is rendered
16+
THEN it should have root and indicator`, async ({ page }) => {
1517
const { driver: d } = await setup(page, 'hero');
1618

1719
await expect(d.getRoot()).toBeVisible();
1820
await expect(d.getProgressIndicator()).toBeVisible();
1921
});
2022

21-
test(`should have progress state loading if is not completed`, async ({ page }) => {
23+
test(`GIVEN a progress
24+
WHEN progress is not completed
25+
THEN it should have progress state loading`, async ({ page }) => {
2226
const { driver: d } = await setup(page, 'hero');
2327

24-
expect(d.getProgressIndicator()).toBeVisible();
28+
await expect(d.getProgressIndicator()).toBeVisible();
2529
expect(await d.getProgressState()).toBe('loading');
2630
expect(await d.getProgressValue()).toBe('30');
2731
});
32+
});
2833

29-
test(`should have aria attributes`, async ({ page }) => {
34+
test.describe('A11y', () => {
35+
test(`GIVEN a progress
36+
WHEN the progress is rendered
37+
THEN it should have aria-valuemin attribute`, async ({ page }) => {
3038
const { driver: d } = await setup(page, 'hero');
3139
await expect(d.getRoot()).toHaveAttribute('aria-valuemin', '0');
40+
});
41+
42+
test(`GIVEN a progress
43+
WHEN the progress is rendered
44+
THEN it should have aria-valuemax attribute`, async ({ page }) => {
45+
const { driver: d } = await setup(page, 'hero');
3246
await expect(d.getRoot()).toHaveAttribute('aria-valuemax', '100');
47+
});
48+
49+
test(`GIVEN a progress
50+
WHEN the progress is rendered
51+
THEN it should have aria-valuenow attribute`, async ({ page }) => {
52+
const { driver: d } = await setup(page, 'hero');
3353
await expect(d.getRoot()).toHaveAttribute('aria-valuenow', '30');
54+
});
55+
56+
test(`GIVEN a progress
57+
WHEN the progress is rendered
58+
THEN it should have aria-valuetext attribute`, async ({ page }) => {
59+
const { driver: d } = await setup(page, 'hero');
3460
await expect(d.getRoot()).toHaveAttribute('aria-valuetext', '30%');
3561
});
3662
});

0 commit comments

Comments
 (0)