Skip to content

Commit e0a2fd7

Browse files
r-barnesfacebook-github-bot
authored andcommitted
Del redundant-static-def in executorch/schema/extended_header.cpp +2 (pytorch#13875)
Summary: LLVM has a warning `-Wdeprecated-redundant-constexpr-static-def` which raises the warning: > warning: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated Since we are now on C++20, we can remove the out-of-line definition of constexpr static data members. This diff does so. - If you approve of this diff, please use the "Accept & Ship" button :-) Differential Revision: D81359733
1 parent 2845fd3 commit e0a2fd7

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

schema/extended_header.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,5 @@ uint64_t GetUInt64LE(const uint8_t* data) {
9191
};
9292
}
9393

94-
// Define storage for the static.
95-
constexpr char ExtendedHeader::kMagic[kMagicSize];
96-
9794
} // namespace runtime
9895
} // namespace executorch

0 commit comments

Comments
 (0)