Skip to content

fix: promote unsigned integers to double to prevent overflow #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: promote unsigned integers to double to prevent overflow #413

wants to merge 1 commit into from
+12 −4

Conversation

@philtran
Copy link

Attempt to fix #412 , #171 , #132

Adds is_unsigned parameter to variable_type_from_field_type, and for unsigned ints (MYSQL_TYPE_LONG), will promote to MY_DBL instead of MY_INT32

@philtran
Copy link
Author

@krlmlr Are you the best person to ask to look at/review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Large Unsigned ints Overflow issue revised

1 participant

@philtran