-
Notifications
You must be signed in to change notification settings - Fork 8
Description
In #68 (comment) there is a link to a fork of the R source code with updates to ensure glyphFont() only produces a single font description, giving warnings if arguments are longer than one.
The next steps are to run standard checks on the patch and perform visual regression testing.
Get and apply the patch
You can get a patch file of the difference between the proposed solution and the latest R source by visiting the following URL
https://github.com/r-devel/r-svn/compare/main...szimmer:r-svn:PR18787.diff
Save the content of the HTML page as PR18787.diff.
Checkout the latest version of the R sources, e.g. by Setting up the R Dev Container in GitHub Codespaces and following steps 1-3 of the Building R tutorial.
Apply the patch with
svn patch <path/to/patch>/PR18787.diff
(if you are in the R Dev Container, you will need to upload the patch file into the workspace first).
Build R and run a full check
Build R, e.g. by following steps 4-6 of the Building R tutorial.
Run a full check by running
make check-all
in the build directory
Run visual regression tests
There are notes on this in the parent issue, see #68 (comment) and following comment.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status