Skip to content

Commit 99ccbf2

Browse files
committed
Merge remote-tracking branch 'origin/devel' into docs/229-codespace-management
2 parents c412447 + 8d17912 commit 99ccbf2

File tree

8 files changed

+31
-65
lines changed

8 files changed

+31
-65
lines changed

.devcontainer/devcontainer.json

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,28 @@
11
{
22
"name": "R-Dev-Env",
33
"image": "ghcr.io/r-devel/r-dev-env:devel",
4+
"remoteUser": "vscode",
45
"hostRequirements": {
56
"cpus": 4
67
},
78
"customizations": {
89
"vscode": {
910
"settings": {
11+
"git.ignoredRepositories": ["."],
12+
"files.exclude": {
13+
"**/.vscode": true,
14+
"**/.devcontainer": true,
15+
"**/.git": true,
16+
"**/.github": true,
17+
"**/.gitignore": true,
18+
"**/.gitpod.Dockerfile": true,
19+
"**/.gitpod.yml": true,
20+
"**/.markdownlint-cli2.yaml": true,
21+
"**/.pre-commit-config.yaml": true,
22+
"**/Dockerfile": true,
23+
"**/mkdocs.yml": true,
24+
"**/scripts": true
25+
},
1026
"editor.tabSize": 8,
1127
"editor.indentSize": 4,
1228
"editor.detectIndentation": false,
@@ -19,16 +35,18 @@
1935
"workbench.editorAssociations": {
2036
"*.md": "vscode.markdown.preview.editor"
2137
},
22-
"workbench.welcomePage.walkthroughs.openOnInstall": false
38+
"workbench.welcomePage.walkthroughs.openOnInstall": false,
39+
"r.libPaths": ["/usr/local/lib/R/site-library"]
2340
},
2441
"extensions": [
2542
"REditorSupport.r",
2643
"mads-hartmann.bash-ide-vscode",
2744
"johnstoncode.svn-scm",
2845
"ms-vscode.cpptools",
29-
"MS-vsliveshare.vsliveshare"
46+
"MS-vsliveshare.vsliveshare",
47+
"natqe.reload"
3048
]
3149
}
3250
},
33-
"postCreateCommand": "find . -wholename '*.git*' -type d -prune -o -type f -exec chown vscode:vscode {} \\; && sh /workspaces/r-dev-env/scripts/localscript.sh"
51+
"postCreateCommand": "sh /workspaces/r-dev-env/scripts/localscript.sh"
3452
}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ R-devel.tar.gz
55
/venv
66
.cache/
77
.Rproj.user
8+
.vscode/

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,5 @@ RUN Rscript -e "runiverse <- sprintf('r-universe.dev/bin/linux/%s-%s/%s/', \
3030
# Define env var used in GitHub Actions that build and deploy container
3131
ARG CONTAINER_VERSION
3232
ENV CONTAINER_VERSION=${CONTAINER_VERSION}
33+
34+
USER vscode

docs/tutorials/contribution_workflow.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ make
6767
may skip this step while you are iterating on a bug fix or other development,
6868
until you are ready to [create a patch](./patch_update.md).
6969

70-
- To use the re-built R, simply open a new R terminal.
70+
- To use the re-built R, simply open a new R terminal. If you have made changes
71+
to the help files, click "Reload" in the VS Code status bar (bottom right) to
72+
reload your VS Code window.
7173

7274
#### 4. Cross check and Re-running Code
7375

reinstall-cmake.sh

Lines changed: 0 additions & 58 deletions
This file was deleted.

scripts/localscript.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ cat $WORK_DIR/scripts/welcome_msg.sh >> ~/.bashrc
2525
#bash ~/.bashrc
2626

2727
# Remove git directory if it exists
28-
rm -rf .git
28+
#rm -rf .git
2929

3030
# copying vscode extension settings from devcontainer json to vscode settings json using jq
3131
if [ -f "$DEVCONTAINER_JSON" ]; then

scripts/welcome_msg.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Have fun \U0001F601
2929
"
3030

3131
# open INDEX.md if INIT file exists
32-
if [ -f "INIT" ]; then
32+
if [ ! -d "svn" ] && [ ! -d "build" ]; then
3333
sleep 2
3434
code INDEX.md
3535
rm INIT

scripts/which_r.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@ which_r() {
6060
fi
6161

6262
# Update settings.json with the chosen R path
63-
updated_settings_data=$(cat "$settings_file_path" | jq --arg subdir "$selected_version" '."r.rterm.linux"=$subdir')
63+
updated_settings_data=$(cat "$settings_file_path" | jq --arg subdir "$selected_version" '."r.rterm.linux"=$subdir | ."r.rpath.linux"=$subdir')
6464
echo "$updated_settings_data" > "$settings_file_path"
6565

6666
echo "R terminal will now use version: $selected_version"
67+
echo "To update the HTML help, click \"Reload\" in the VS Code status bar (bottom right) to reload your VS Code window."
6768
}

0 commit comments

Comments
 (0)