Skip to content

Commit 2a56d7a

Browse files
author
maechler
committed
crossprod() & tcrossprod(), now internally S4 generic, no need for implicit; PR#18830
git-svn-id: https://svn.r-project.org/R/trunk@87413 00db46b3-68df-0310-9c12-caf00c1e9a41
1 parent ac91f25 commit 2a56d7a

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/library/methods/R/makeBasicFunsList.R

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -251,14 +251,8 @@ utils::globalVariables(".addBasicGeneric")
251251
setGenericImplicit("rowMeans", where, FALSE)
252252
setGenericImplicit("rowSums", where, FALSE)
253253

254-
setGeneric("crossprod", function(x, y = NULL, ...) standardGeneric("crossprod"),
255-
useAsDefault = function(x, y = NULL, ...) base::crossprod(x, y),
256-
signature = c("x", "y"), where = where)
257-
setGeneric("tcrossprod", function(x, y = NULL, ...) standardGeneric("tcrossprod"),
258-
useAsDefault = function(x, y = NULL, ...) base::tcrossprod(x, y),
259-
signature = c("x", "y"), where = where)
260-
setGenericImplicit("crossprod", where, FALSE)
261-
setGenericImplicit("tcrossprod", where, FALSE)
254+
## "crossprod" and
255+
## "tcrossprod" have been made internal (S3 and) S4 generics see .BasicFunsList
262256

263257
setGeneric("sample", function(x, size, replace = FALSE, prob = NULL, ...)
264258
standardGeneric("sample"),
@@ -295,7 +289,6 @@ utils::globalVariables(".addBasicGeneric")
295289
signature = "x", where = where)
296290
setGenericImplicit("svd", where, FALSE)
297291

298-
299292
## zapsmall(): signature only "x"
300293
setGeneric("zapsmall", function(x, digits = getOption("digits"),
301294
mFUN = function(x, ina) max(abs(x[!ina])), min.d = 0L, ...)

0 commit comments

Comments
 (0)