Skip to content

Commit 343ecf2

Browse files
author
ripley
committed
add comments
git-svn-id: https://svn.r-project.org/R/trunk@87951 00db46b3-68df-0310-9c12-caf00c1e9a41
1 parent 920f616 commit 343ecf2

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

m4/R.m4

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4579,6 +4579,7 @@ LIBS="${r_save_LIBS}"
45794579
if test "x${r_cv_icu}" = xyes; then
45804580
AC_DEFINE(USE_ICU, 1, [Define to use ICU for collation.])
45814581
LIBS="${LIBS} -licuuc -licui18n"
4582+
dnl why does this append when everything else prepends? Including on macOS
45824583
else
45834584
use_ICU=no
45844585
fi

src/include/R_ext/Boolean.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
#ifndef R_EXT_BOOLEAN_H_
2727
#define R_EXT_BOOLEAN_H_
2828

29+
// NB: there is a version of this in Rmath.h0[.in]
30+
2931
#undef FALSE
3032
#undef TRUE
3133

src/nmath/standalone/Makefile.in

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,9 @@ inc: Makefile
8989

9090
# check: clean -- takes ~ 5 sec --> just 'rm test':
9191
# : all -- not as dependency, but directly, possibly parallelized:
92+
### NB: we only test the static library, unlike Windows.
93+
### This is becuse of the platform-specific and ever-changing ways
94+
### of finding the just-built DSO/dylib at run time.
9295
check:
9396
@rm -f check.log test
9497
@if test -n "${TEST_MC_CORES}"; then \

0 commit comments

Comments
 (0)