speedup StringFromLogical(); by Suharto Anggono

maechler · maechler · commit 588e6ba09221 · 2025-04-11T08:10:43.000Z
git-svn-id: https://svn.r-project.org/R/trunk@88134 00db46b3-68df-0310-9c12-caf00c1e9a41
diff --git a/src/main/coerce.c b/src/main/coerce.c
@@ -295,12 +295,14 @@ attribute_hidden Rcomplex ComplexFromString(SEXP x, int *warn)
     return z;
 }
 
+
 attribute_hidden SEXP StringFromLogical(int x, int *warn)
 {
-    int w;
-    formatLogical(&x, 1, &w);
+    static SEXP TrueCh = NULL, FalseCh = NULL; /* constants, initialized when first used */
     if (x == NA_LOGICAL) return NA_STRING;
-    else return mkChar(EncodeLogical(x, w));
+    else if (x)
+	 return TrueCh != NULL ? TrueCh  : (TrueCh  = mkChar("TRUE"));
+    else return FalseCh!= NULL ? FalseCh : (FalseCh = mkChar("FALSE"));
 }
 
 /* The conversions for small non-negative integers are saved in a chache. */

Original file line number	Diff line number	Diff line change
`@@ -295,12 +295,14 @@ attribute_hidden Rcomplex ComplexFromString(SEXP x, int *warn)`
`295`	`295`	`return z;`
`296`	`296`	`}`
`297`	`297`
	`298`	`+`
`298`	`299`	`attribute_hidden SEXP StringFromLogical(int x, int *warn)`
`299`	`300`	`{`
`300`		`- int w;`
`301`		`- formatLogical(&x, 1, &w);`
	`301`	`+ static SEXP TrueCh = NULL, FalseCh = NULL; /* constants, initialized when first used */`
`302`	`302`	`if (x == NA_LOGICAL) return NA_STRING;`
`303`		`- else return mkChar(EncodeLogical(x, w));`
	`303`	`+ else if (x)`
	`304`	`+ return TrueCh != NULL ? TrueCh : (TrueCh = mkChar("TRUE"));`
	`305`	`+ else return FalseCh!= NULL ? FalseCh : (FalseCh = mkChar("FALSE"));`
`304`	`306`	`}`
`305`	`307`
`306`	`308`	`/* The conversions for small non-negative integers are saved in a chache. */`